Re: [OS-BUILD PATCH] redhat/Makefile: fix default values for dist-brew's DISTRO and DIST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2339#note_1295688724

This doesn't work, because it'll override anything you set inside
redhat/Makefile.variables. For example if I do this:

```
diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables
index c20fef88a468..1381ffbb7c1d 100644
--- a/redhat/Makefile.variables
+++ b/redhat/Makefile.variables
@@ -30,7 +30,7 @@ BUILD_PROFILE ?=
 # default values can be found in redhat/Makefile and are dependent on the
 # target OS.  The target OS can be changed by setting the DIST or DISTRO
 # variables.
-BUILD_TARGET ?=
+BUILD_TARGET ?= rawhide

 # BUMP_RELEASE determines whether the pkgrelease is bumped when you call
 # 'make dist-release'.  It should be set to "yes" if you expect to do
```

Your patch will override it, even if I want to change the value in
Makefile.variables.

Probably what we want to do is to change the ifdefs. For example:

```
  ifndef BUILD_TARGET
```

to

```
ifeq ("$(BUILD_TARGET)", "")
```

It looks like we should be using ifeq instead. I remember something about
ifdef
not being ideal with make and exported variables.

So switch to ifeq, and see if the remaining changes are really needed or not
here.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux