Hey everyone,
I just posted
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2255 to fix
three build warnings, as well as some output from pathfix.py.
There still are two other build warnings and one set of messages that
need to be fixed but require further discussion.
1) https://src.fedoraproject.org/rpms/kernel-srpm-macros/pull-request/6
Hopefully self-explanatory via the link :) but it fixes the "readelf:
/tmp/find-provides.ksyms.XXXXXX.ko: Warning: Section '.rodata' was not
dumped because it does not exist" errors in the rpm log.
2) The signing code should be moved into it's own script.
If you look at a rpm build log [1] you'll find lines like
<snip>
+ shift
+ shift
+ [[ 15 -ge 2 ]]
+ case " ${1} " in
+ client_cert[0]=-c
+ client_cert[1]='/CN=Fedora Secure Boot Signer'
+ shift
+ shift
+ [[ 13 -ge 2 ]]
+ case " ${1} " in
+ cert[0]=-c
+ cert[1]='Red Hat Test Certificate'
+ shift
<snip>
from the signing code. While the execution of this code is interesting,
I'm not sure it should be verbose in every log. I propose to push this
code into it's own separate script to keep the log a bit cleaner. If
users do need to debug this code they can add an -xv to the bash header
and run through koji that way.
3) The kernel-devel absolute symlink
The log contains this error:
absolute symlink:
/lib/modules/6.2.0-0.rc4.7287904c8771.33.test.fc36.x86_64/build ->
/usr/src/kernels/6.2.0-0.rc4.7287904c8771.33.test.fc36.x86_64
From the kernel.spec.template:2235
# This is going to create a broken link during the build, but we
don't use
# it after this point. We need the link to actually point to something
# when kernel-devel is installed, and a relative link doesn't work
across
# the F17 UsrMove feature.
ln -sf $DevelDir $RPM_BUILD_ROOT/lib/modules/$KernelVer/build
I understand why this link exists, however, I wonder if the link should
be created in the pre-install section of either the kernel-core rpm or
the kernel-devel rpm instead (and of course, clean it up in the
pre-uninstall sections)? AFAICT that would work and would give us a
cleaner rpm build.
P.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
