[OS-BUILD PATCHv2] redhat/Makefile: Fix RHJOBS grep warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Prarit Bhargava <prarit@xxxxxxxxxx>

redhat/Makefile: Fix RHJOBS grep warning

Calculating RHJOBS results in the warning

	grep: warning: stray \ before white space

Resolve this by using [ ] to detect a space in the regex.

Before fix:

Search for "before white space" in https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/688747365/merge/3320666485/artifacts/build.log

After fix:

No "before white space" errors seen in https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/694379019/merge/3320742570/artifacts/build.log

Also, confirming that RHJOBS works correctly after the fix,

[prarit@prarit kernel-ark]$ make -j13 dist-dump-variables | grep RHJOBS=
RHJOBS=13
[prarit@prarit kernel-ark]$

Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>

diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -80,7 +80,7 @@ ifndef DISTRO
 endif
 
 ifndef RHJOBS
-  RHJOBS=$(shell j=$$(echo $(MAKEFLAGS) | grep -Eo "\ -j[0-9]*" | xargs ); \
+  RHJOBS=$(shell j=$$(echo $(MAKEFLAGS) | grep -Eo "(^|[ ])-j[0-9]*" | xargs ); \
 	  if [ -z "$${j}" ]; then \
 	  	echo "1"; \
 	  else \

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2148
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux