From: Patrick Talbert <ptalbert@xxxxxxxxxx>
redhat: Use a context manager in merge.py for opening the config file for reading
Signed-off-by: Clark Williams <williams@xxxxxxxxxx>
diff --git a/redhat/configs/merge.py b/redhat/configs/merge.py
index blahblah..blahblah 100755
--- a/redhat/configs/merge.py
+++ b/redhat/configs/merge.py
@@ -26,14 +26,15 @@ def usage(msg):
# read a config file and return a dictionary of the contents
def read_config_file(cfgfile):
configs = {}
- for l in [ n.strip() for n in open(cfgfile).readlines()]:
- if len(l) == 0: continue
- if l.startswith("# CONFIG_"):
- configs[l.split()[1]] = l
- continue
- if l.startswith("CONFIG_"):
- configs[l.split('=')[0]] = l
- continue
+ with open(cfgfile) as f:
+ for l in [n.strip() for n in f.readlines()]:
+ if not l: continue
+ if l.startswith("# CONFIG_"):
+ configs[l.split()[1]] = l
+ continue
+ if l.startswith("CONFIG_"):
+ configs[l.split('=')[0]] = l
+ continue
return configs
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2117
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
