Re: [OS-BUILD PATCH] redhat: set LC_ALL=C before sorting config content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 13, 2022 at 12:13:07PM -0000 Justin M. Forbes (via Email Bridge) wrote:
> From: Justin M. Forbes on gitlab.com
> https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2011#note_1098634600
> 
> For example, before the change this is all one chunk beginning at line 1138:
> 
> ```
> CONFIG_CLK_RV110X=y
> CONFIG_CLK_SP810=y
> # CONFIG_CLKSRC_STM32_LP is not set
> CONFIG_CLKSRC_VERSATILE=y
> CONFIG_CLK_SUNXI_CLOCKS=y
> # CONFIG_CLK_SUNXI_PRCM_SUN6I is not set
> # CONFIG_CLK_SUNXI_PRCM_SUN8I is not set
> CONFIG_CLK_SUNXI_PRCM_SUN9I=y
> CONFIG_CLK_SUNXI=y
> ```
> 
> after the change this is split into:
> 
> Line 335:
> 
> ```
> # CONFIG_CLKSRC_STM32_LP is not set
> # CONFIG_CLK_GFM_LPASS_SM8250 is not set
> # CONFIG_CLK_IMX8ULP is not set
> # CONFIG_CLK_IMX93 is not set
> # CONFIG_CLK_SUNXI_PRCM_SUN6I is not set
> # CONFIG_CLK_SUNXI_PRCM_SUN8I is not set
> ```
> 
> line 3433:
> 
> ```
> CONFIG_CLK_RV110X=y
> CONFIG_CLK_SP810=y
> CONFIG_CLK_SUNXI=y
> CONFIG_CLK_SUNXI_CLOCKS=y
> CONFIG_CLK_SUNXI_PRCM_SUN9I=y
> CONFIG_CLK_VEXPRESS_OSC=y
> ```
> 
> The sorting is not logical at all, and options move to a completely different
> place in the file based on what they are set to.

The former is _much_ better. 


Cheers,
Phil

> _______________________________________________
> kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
> Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

-- 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux