From: Prarit Bhargava <prarit@xxxxxxxxxx>
redhat/self-test: Fix shellcheck errors
Fix shellcheck errors.
Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
diff --git a/redhat/self-test/data/create-data.sh b/redhat/self-test/data/create-data.sh
index blahblah..blahblah 100755
--- a/redhat/self-test/data/create-data.sh
+++ b/redhat/self-test/data/create-data.sh
@@ -16,6 +16,7 @@
# Store variables used in *this* script before unsetting them below.
destdir="${RHDISTDATADIR}"
+# shellcheck disable=SC2153
sources="${SOURCES}"
# unset all redhat/Makefile variables so they do not interfere with make targets below
@@ -26,10 +27,10 @@ specfile_helper () {
local specfilename
specfilename=$1
- cp ./kernel.spec.template ${varfilename}.spec.template
- make RHSELFTESTDATA=1 SPECFILE="${specfilename}.spec" DIST="${DIST}" DISTRO="${DISTRO}" HEAD=${commit} _setup-source
+ cp ./kernel.spec.template "${varfilename}.spec.template"
+ make RHSELFTESTDATA=1 SPECFILE="${specfilename}.spec" DIST="${DIST}" DISTRO="${DISTRO}" HEAD="${commit}" _setup-source
grep -Fvx -f "${specfilename}.spec.template" "${sources}/${specfilename}.spec" > "${destdir}"/"${specfilename}".spec
- rm -f ${specfilename}.spec.template
+ rm -f "${specfilename}.spec.template"
}
for DISTRO in fedora rhel centos
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1993
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
