From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900#note_1013368484 >builddep can be passed a spec file or srpm as well, unfortunately it seems to choke if passed the kernel.spec.template, so we would need a processed template into a proper spec. hehe :) Yeah, the double-percent issue. I ran into that too :) @dzickusrh had an objection to running the install from within the makefile. I tend to lean towards his viewpoint; let the user make a decision if they want to install the packages or not. Let's just output a list of the packages and let the user decide what they need to do. It's also possible (see system-sb-certs) that a package may not exist on the OS. I'm planning on calling setup-source, just like dist-buildreq-check does today. There's still a small problem that I'm worried about: The setup-source target may require packages to be installed as well, and if tell people to execute a target that calls setup-source we may end up a catch-22. AFAICT setup-source only seems to call bash and simple commands so maybe it's not a problem. Additionally, I need to think about how to test this target. That's a bit tricky and I'll need @veruu and the CKI team's help in setting up a test. I need a "plain" builder_image without any dependencies installed. The first test to run would be to confirm a, for example, 'make dist-srpm' failure. The second test, would be to call the new dist-* target to list the dependencies, install the dependencies, and then run 'make dist-srpm' to confirm that the new dist-* target worked. ^^^ I suspect that @veruu and the CKI team are laughing at me for not knowing how easy this is to do :) :) but I'm not overly familiar with CI and will need a bit of hand-holding the first time I add a test like this. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
