[OS-BUILD PATCH 2/2] redhat/Makefile: Add DIST_BUILDREQ_WARN variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Prarit Bhargava <prarit@xxxxxxxxxx>

redhat/Makefile: Add DIST_BUILDREQ_WARN variable

dist-* targets will fail if packages required by the build are not
installed.  In some cases, such as dist-configs, the build packages are
not required for command execution.

Provide a DIST_BUILDREQ_WARN variable that allows users to skip dist-*
errors due to missing packages.

Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>

diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -454,12 +454,19 @@ dist-buildreq-check: setup-source
 	for pkg in $$PKGLIST; do \
 		rpm -q --whatprovides $$pkg >/dev/null || MISSING="$$MISSING $$pkg"; \
 	done; \
+	warn="Error"; \
+	if [ -n "$$DIST_BUILDREQ_WARN" ]; then \
+		warn="Warning"; \
+	fi; \
 	if [ -n "$$MISSING" ]; then \
-		echo "Error: please install $$MISSING"; \
+		echo "$$warn: Please install: $$MISSING"; \
 		if  echo "$$MISSING" | grep -q system-sb-certs ; then \
-			echo "Error: system-sb-certs can be installed from the CodeReady Linux Builder (CRB) repository."; \
+			echo "$$warn: system-sb-certs can be installed from the CodeReady Linux Builder (CRB) repository."; \
+		fi; \
+		if  [ $$warn == "Error" ]; then \
+			echo "$$warn: These errors can be skipped by specifying DIST_BUILDREQ_WARN=1."; \
+			exit 1; \
 		fi; \
-		exit 1; \
 	fi
 
 setup-source: dist-git-version-check dist-clean-sources

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux