Re: [OS-BUILD PATCH 0/4] redhat: Fixup self-tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1800#note_971239371

This is really not pretty, and makes you have to hack places where it's
sensitive to the double variable output.

I'm not a make expert, but finally I reached something that seems to work, if
I understood the problem correctly:

```
diff --git a/redhat/Makefile b/redhat/Makefile
index 660801fab39a..480f76750bae 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -714,7 +714,8 @@ dist-os-version:
        @echo "OSVERSION: $(RHEL_MAJOR).$(RHEL_MINOR)"

 dist-dump-variables:
-       @$(foreach V,$(sort $(.VARIABLES)), $(if $(filter-out environment%
default automatic, $(origin $V)),$(info $V=$($V) )))
+       $(eval VARS:=$(sort $(shell cat Makefile.variables | sed '/^#/d;
/^$$/d; s/[ ]*[?:]=.*//')))
+       @$(foreach V,$(sort $(.VARIABLES)), $(if $(filter-out environment
default automatic, $(origin $V)),$(info $V=$($V) ),$(if $(filter
$(VARS),$(V)),$(info $V=$($V)))))

 dist-self-test:
        @if test -x /usr/bin/bats; then \
```

What do you think?
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux