From: Prarit Bhargava <prarit@xxxxxxxxxx> self-test: Fixup Makefile contents test The redhat/Makefile contains a "?=" that is caught up in the grep of the Makefile contents test [1]. Ignore the match in the test. [1] redhat/Makefile:716 @cat Makefile.variables | grep -v "^#" | sed '/^$$/d' | tr -d " " | awk -F "?=|:=" '{print $$1}' | while read -r VAR ; do \ Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx> diff --git a/redhat/self-test/3001-Makefile-contents.bats b/redhat/self-test/3001-Makefile-contents.bats index blahblah..blahblah 100755 --- a/redhat/self-test/3001-Makefile-contents.bats +++ b/redhat/self-test/3001-Makefile-contents.bats @@ -9,7 +9,7 @@ exit 1 fi - value=$(git grep "?=" Makefile | wc -l) + value=$(git grep "?=" Makefile | grep -v "\"?=" | wc -l) if [ $value -gt 0 ]; then echo "Test failed: Makefile should not ?= declarations." exit 1 -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1800 _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure