Re: [OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_949496617

>It definitely depends on the repo.  I think I had so more garbage that it
inflated things.  'git gc' removed enough junk that my 'git log --oneline' is
down to 12.
>
>Looking into this more.
>
>SPECBUILD uses PREBUILD.  PREBUILD is based on MARKER which is based on
MERGE_HEAD with upstream. The point of SPECBUILD is to have a sha to describe
upstream merge base.  The argument becomes if upstream relies on 12, then that
should good enough to use as a description in SPECBUILD.
>
>Now the user's local enviornment may change but it should be rare??  In my
case I can get away with 6 as my minimum merge base MARKER (for uniqueness) ('
--abbrev=4' but shows 6).
>
>So I guess I can logically convince myself that 12 is fine by me.
>
>@prarit thoughts?

One day you want 15, then 13, then 12 :)  Make up your mind!!!!! :) :) :)

It's not a problem and is a one line change.  I'll submit (yet another ;))
MR to drop this back to 12.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux