From: Prarit Bhargava <prarit@xxxxxxxxxx> redhat/Makefile: Drop quotation marks around string definitions dzickus reports that 'make dist-srpm-gcov' doesn't work anymore. Not only is an error reported, error: line 555: Illegal char '"' (0x22) in: Release: 0.rc7.53".gcov".fc35 error: query of specfile /home/prarit/git-kernel/kernel-ark/redhat/rpm/SOURCES/kernel.spec failed, can't parse but the resulting specfile does not contain '%define _with_gcov 1'. Exporting the Makefile variables into the scripts results in quotation marks now being interpreted as part of the string. As can be seen in the error above the quotation mark is the problem. Drop quotation marks around string definitions. Reported-by: Don Zickus <dzickus@xxxxxxxxxx> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx> diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -567,8 +567,8 @@ dist-all-rpms: dist-sources do-rpmbuild dist-srpm: RPMBUILDOPTS=--nodeps -bs dist-srpm: dist-sources do-rpmbuild -dist-srpm-gcov: BUILDID=".gcov" -dist-srpm-gcov: BUILDOPTS+="+gcov" +dist-srpm-gcov: BUILDID=.gcov +dist-srpm-gcov: BUILDOPTS+=+gcov dist-srpm-gcov: dist-srpm dist-rpms: RPMBUILDOPTS=--target $(MACH) -bb -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1782 _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
