Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Thorsten Leemhuis on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_945430959

Many thx for your reply.

> Filing issues would be helpful. If you can, please @ notify me in those
issues.

You sure about this? From the other stuff you wrote it seems you already have
a battle plan for cleaning up kernel.spec and I don't think I provided any
bright new insights for that. So maybe I'll just let you continue doing your
work -- and once you get down to it I'll take time for a closer look at the
changes to provide and feedback and an extra set of eyes then.

>> * is there a specific reason why kernel-ark is using the first 15
characters of the commit-id for snapshot naming instead of just 12 characters,
as typically used by kernel developers upstream? I ask as I ran into failures
like `5.18.0-0.rc0.20220401gite8b767f5e04097a.15.vanilla.1.fc36.aarch64
exceeds 64 characters` with my vanilla builds. Seems the `20220401git` part is
gone after these patches which would solve this for me, but I'd say being more
in line with what upstream typically does would be nice.

> @dzickusrh requested future proofing of this field. I have no issue with
changing this back to the current linux standard 12-characters, however, there
is some merit into his thoughts for the future.

I can understand that line of thought, but I think being closer in line with
what upstream does would be nice and leaves a bit more space for people that
use local tags. And I guess Linux upstream sooner or later will talk about
switching to sha256sums anyway, which might be a point where they will switch
to a longer shorted value anyway which kernel-ark could pick up then.

But I don't care too much if there are say at least say 10 to 15 characters
left for people to apply a local tag to their packages (like my '.vanilla').
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux