From: Prarit Bhargava <prarit@xxxxxxxxxx> redhat/genspec.sh: Add comment about SPECBUILDID variable Add a comment about the non-obvious use of SPECBUILDID in the specfile. Move the definition of SPECRELEASE to a better location. Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx> diff --git a/redhat/genspec.sh b/redhat/genspec.sh index blahblah..blahblah 100755 --- a/redhat/genspec.sh +++ b/redhat/genspec.sh @@ -29,6 +29,10 @@ else SPECBUILDID="# define buildid .local" fi +# The SPECRELEASE variable uses the SPECBUILDID variable which is +# defined above. IOW, don't remove SPECBUILDID ;) +SPECRELEASE="${PREBUILD}""${BUILD}""%{?buildid}%{?dist}" + EXCLUDE_FILES=":(exclude,top).get_maintainer.conf \ :(exclude,top).gitattributes \ :(exclude,top).gitignore \ @@ -56,8 +60,6 @@ if [ "$PATCHLIST_URL" != "none" ]; then SPECPATCHLIST_CHANGELOG=1 fi -SPECRELEASE="${PREBUILD}""${BUILD}""%{?buildid}%{?dist}" - # self-test begin test -f "$SOURCES/$SPECFILE" && sed -i -e " -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757 _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure