Re: Race found with parallel config processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 22, 2022 at 06:48:17PM -0400, Prarit Bhargava wrote:
> On 3/22/22 17:10, Frantisek Hrbata wrote:
> > 
> > On Tue, Mar 22, 2022, 21:46 Prarit Bhargava <prarit@xxxxxxxxxx
> > <mailto:prarit@xxxxxxxxxx>> wrote:
> > 
> >     On 3/22/22 15:41, Prarit Bhargava wrote:
> >      > On 3/22/22 15:37, Prarit Bhargava wrote:
> >      > <snip>
> >      >
> >      >> Thanks, I had thought that too but :( I get an error when running
> >      >> 'make scripts-basic'?
> >      >>
> >      >> [prarit@prarit kernel-ark]$ make V=1 scripts_basic
> >      >> ***
> >      >> *** Configuration file ".config" not found!
> >      >> ***
> >      >> *** Please run some configurator (e.g. "make oldconfig" or
> >      >> *** "make menuconfig" or "make xconfig").
> >      >> ***
> >      >> make: *** [Makefile:711: .config] Error 1
> >      >>
> >      >> I could have screwed something up though?
> >      >
> >      > Ah nvm, lokoks like you have to have a .config in place before
> >     executing
> >      > the command.  Let me see what I can do about that.
> >      >
> > 
> >     I'm going to try
> > 
> >     diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
> >     index 3444672050c7..ca54ea855e57 100755
> >     --- a/redhat/kernel.spec.template
> >     +++ b/redhat/kernel.spec.template
> >     @@ -1455,6 +1455,8 @@ for opt in %{clang_make_opts}; do
> >          OPTS="$OPTS -m $opt"
> >        done
> >        %endif
> >     +
> >     +(cd ..; make %{?_smp_mflags} allnoconfig scripts_basic; rm -f .config)
> >        ./process_configs.sh $OPTS kernel %{rpmversion}
> > 
> >        cp %{SOURCE82} .
> > 
> >     to see if that resolves the problem.
> > 
> > 
> > But this would not solve the problem for running make dist-configs
> > directly, right?
> 
> Yes, that's correct.  It's just a quick test to see if the issue is, in
> fact, scripts_basic.
> 
> > E.g. I want to check locally that my configuration changes generate the
> > expected configuration file.
> > 
> 
> I'm going to have to check for the existence of ../.config, and if it does
> not exist then execute 'make allnoconfig scripts_basic' for a "real" fix.

Note that for all %config targets the config-build=1 is set and the config check
steps are not included. You can see that in the main Makefile if you
search for config-build. I doesn't make much sence to require config
to generate one.

I think the following seems like a one way to do this.

make scripts_basic config-build=1

As always I for sure am missing something and maybe there is
better/proper way how to compile stand alone fixdep without config, but
at this point I cannot think of anything better.

> 
> P.
> 
> > 
> >     P.
> > 
> 

-- 
Frantisek Hrbata
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux