[OS-BUILD PATCH 1/2] redhat/configs/process_configs.sh: Remove CONTINUEONERROR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Prarit Bhargava <prarit@xxxxxxxxxx>

redhat/configs/process_configs.sh: Remove CONTINUEONERROR

Back when process_configs.sh was serial, CONTINUEONERROR allowed the
process_configs.sh script to continue to the next config even when there
was a fatal error with the current analysis.  This is no longer needed in
the script.

Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>

diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh
index blahblah..blahblah 100755
--- a/redhat/configs/process_configs.sh
+++ b/redhat/configs/process_configs.sh
@@ -105,7 +105,6 @@ checkoptions()
 		! $checkoptions_error && return
 
 		sed -i "1s/^/Error: Mismatches found in configuration files for ${arch} ${variant}\n/" .mismatches"${count}"
-		[ "$CONTINUEONERROR" ] || exit 1
 	else
 		rm -f .mismatches"${count}"
 	fi
@@ -260,7 +259,6 @@ function process_config()
 		cat .newoptions"${count}" >> .errors"${count}"
 		rm .newoptions"${count}"
 		RETURNCODE=1
-		[ "$CONTINUEONERROR" ] || exit 1
 	fi
 	rm .newoptions"${count}"
 
@@ -270,7 +268,6 @@ function process_config()
 		echo "Found misconfigured config items in ${arch} ${variant}, please set them to an appropriate value" >> .errors"${count}"
 		cat .warnings"${count}" >> .errors"${count}"
 		rm .warnings"${count}"
-		[ "$CONTINUEONERROR" ] || exit 1
 	fi
 	rm .warnings"${count}"
 
@@ -340,7 +337,6 @@ function process_configs()
 }
 
 CHECKOPTIONS=""
-CONTINUEONERROR=""
 NEWOPTIONS=""
 TESTRUN=""
 CHECKWARNINGS=""
@@ -355,7 +351,6 @@ do
 	case $key in
 		-a)
 			CHECKOPTIONS="x"
-			CONTINUEONERROR="x"
 			NEWOPTIONS="x"
 			CHECKWARNINGS="x"
 			;;
@@ -365,9 +360,6 @@ do
 		-h)
 			usage
 			;;
-		-i)
-			CONTINUEONERROR="x"
-			;;
 		-n)
 			NEWOPTIONS="x"
 			;;

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1712
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux