From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1642#note_887468295 @prarit said: ``` The test is dependent on the dist-release adding the tag. I've been thinking about HEAD and have some other ideas unrelated to the tests about how to deal with it. ``` Ok, so that is fine then. ``` These tests will be run as part of CI. In that case there will always be ONE test. The problem with local execution is that if there are many SRPMs it may not be obvious which specific SRPM should be consumed. It could be the user has a broken SRPM because they are testing code, etc. I do think the SRPM test is interesting in the long term to identify dist-srpm issues but certainly can be convinced otherwise. I'm not convinced all the tests are truly valid tests. ``` So again, if we are using an srpm to validate a test, the self-tests needs to generate it using the current code. In the case of multiple SRPMS, we should know what the name is going to be, right? We have the Makefile and env logic. If this test does not need the SRPM, then the 'skip' seems odd. Or are you just trying to fix up a test that you have no idea why it exists (because it may not be obvious)? _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
