From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_708131064 @jstancek - i tried to spend about a half hour thinking about this. As I saw other config changes using 'sed' in the kernel.spec file, I thought about using something like kernel.local but calling it kernel.gcov. Playing with the idea started to add some complexity. Mainly, I was frustrated that I had to see the failures in Brew instead of locally with some sort of 'make dist-configs' variant. And with your change I am not sure if that hides other things that should be enabled. For example CONFIG_GCOV_PROFILE_ALL would have been disabled if it wasn't already explicitly enabled in the spec file. Meanwhile the only option missing is redhat/configs/common/generic/CONFIG_GCOV_PROFILE_FTRACE. I think I am ok with just adding the above config to the sed line and moving along. Though I see where you are going with the gcov variant idea. I wonder if that causes issues later with -rt and -auto variants later. Thoughts? _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
