From: Ondrej Mosnáček on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1284#note_663080152 Ok, you're almost there, but I'd like to see this information captured *in the commit message*. Years later, someone might wonder why `=y` was chosen for `CONFIG_TRUSTED_KEYS`. They should be able to just do `git log redhat/configs/common/generic/CONFIG_TRUSTED_KEYS` and see in the commit message the reasoning (e.g. something like "Set TRUSTED_KEYS to =y in both Fedora and RHEL, as otherwise <thing> breaks because IMA needs to use trusted keys early in the boot process."). This is what every developer should strive for in every commit message - explaining the "why" behind the change is crucial. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
