From: Michael Petlan on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1167#note_596500733 > > Justin Forbes commented: > > Curious on this, as Fedora has been building with CORESIGHT for a bit now (since July 2020). We did not case the changes on arch, and simply added openscd-devel as a buildreq for everyone and pass CORESIGHT=1 > to perf_make. This builds fine across all arches, even though it is unnecessary. As coresight is an arm specific thing, it is really only used in arch/arm/util/ files and shouldn't be a problem for other > architectures. Which makes me ask, do we trade spec complexity for more specific build command line, or do we go the simple spec route and expect it to continue working? I prefer cutting this down to be arm-specific and "trade the spec file complexity", since I see no reason for x86 (and other arch) customers (which I believe is a majority) to install completely useless packages. I tend to the idea that we should keep RHEL composes tiny, since it looks that this is the strategy for it as a platform. And sacrificing few more lines in spec to this is not that high price. Also, there already are arch- specific build-reqs. A better question is, whether linking opencsd would allow the x86 users to e.g. analyse the coresight trace from perf.data obtained on aarch64. In such case, it would make sense. But, to be honest, I don't see this ability there, I haven't noticed any customer interest in that, any mention in the docs about it (maybe I am missing something!), so I decided this way. But as I say, extended functionality is an argument for linking it everywhere, spec simplicity seems not to be enough in my opinion. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
