From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_585698139 > If I need to push an other version I can add the Fedora update as well. This MR already got way bigger than I expected. So I don't see a problem in adding one more commit. Either way, if you do it in this request, I am happy to take it. If it goes in as a separate MR, fedora specific changes do not require the same ack structure. I review/ack/merge, though with s390x I tend to take whatever you folks recommend. > My understanding so far was that common/ should contain configs that are shared between ark and fedora and not that common/ contains the defaults which can be overwritten in ark/ and fedora/. This is indeed the case in theory, if an entry is in common, it should ideally be the same, with no corresponding entry in fedora or ark directory. In practice, the scripts tend to generate a bit differently. The intention is to run a clean up script on a regular interval which consolidates entries in fedora and ark if they are the same, and removes common if they are different. For this particular case I don't think an entry is necessary in common if they are going to be different, but I do have to ask if we really need them to be different. Does Fedora need to support older hardware here? I am fine with either answer, I really don't know what hardware people are running Fedora on for s390x. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
