Re: [OS-BUILD PATCH] Keep sctp and l2tp modules in modules-extra

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 07, 2021 at 07:02:27PM -0000, Justin Forbes (via Email
Bridge) wrote:
> From: Justin Forbes on gitlab.com
> https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1117#note_570213935
>
> > Anyway, the commands I used are: time find . -name "Makefile\*" -exec
> grep '.o' {} ; > /tmp/don.list (3 seconds) for i in `cat
> redhat/rhel_files/*.list.rhel redhat/fedora_files/*.list.fedora`;do
> mod="$(echo $i | sed 's/ko$/o/')"; grep -q $mod /tmp/don.list || echo
> "Bad module: $i"; done|wc -l
>
> I don't think that addresses the issue, I think the issue is when a new
> module comes along with a dep on a module that was in extras, and moves
> the extras module back to kernel-modules.   The only real way to do that
> is to diff the file lists of module every time and list anything missing
> that was in the previous verison.

Or treat mod-extra.list (and others) as mandatory. If it's there, and
the module is not listed in the final file list, as in:
%{expand:%%files -f %{name}-%{?3:%{3}-}modules-extra.list
%{?3:%{3}-}modules-extra}\
it's a bug.

That said, the best place to handle it would be while building the package.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux