From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1042#note_560989196 While I'm not expert on grub themes, I wonder if "grub_class kernel" should be left here for compatibility, if there is any theme today which would care about it. Another point I have also is regarding: "grub_class ${ID_LIKE:-${ID}}". >From what I understand you try to keep the 10_linux behaviour. However, on RHEL ID_LIKE == fedora. So I wonder if we really should default to ID_LIKE, but instead use ID only here always. If using ID_LIKE, both rhel and fedora kernels will install with "grub_class fedora". If we use ID, fedora kernels will be "grub_class fedora" while on rhel its kernels will be "grub_class rhel". Besides these two points, all other changes looks good to me. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
