[PATCH] drm/i915/tgl/psr: Disable PSR on Tigerlake for now

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Currently PSR2 appears to be broken on TGL which causes some pretty nasty
refresh issues. Intel doesn't have a fix for this quite yet, and this
definitely affects a couple of OEM machines shipping with Fedora.

We don't have a better workaround for the time being, so just disable PSR2
outright for Tigerlake by default until this gets fixed.

Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>
Cc: Jared Dominguez <jaredz@xxxxxxxxxx>
Cc: Mark Pearson <markpearson@xxxxxxxxxx>
Bugzilla: https://gitlab.freedesktop.org/drm/intel/-/issues/3134
---
 drivers/gpu/drm/i915/display/intel_psr.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 850cb7f5b332..48ea3a42feb2 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1817,9 +1817,14 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
 		 */
 		dev_priv->hsw_psr_mmio_adjust = _SRD_CTL_EDP - _HSW_EDP_PSR_BASE;
 
-	if (dev_priv->params.enable_psr == -1)
-		if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable)
+	if (dev_priv->params.enable_psr == -1) {
+		if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable) {
 			dev_priv->params.enable_psr = 0;
+		} else if (INTEL_GEN(dev_priv) == 12) {
+			/* See https://gitlab.freedesktop.org/drm/intel/-/issues/3134 */
+			dev_priv->params.enable_psr = 0;
+		}
+	}
 
 	/* Set link_standby x link_off defaults */
 	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
-- 
2.30.2
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux