Re: [OS-BUILD PATCHv3] redhat: add initial support for centos stream dist-git sync on Makefiles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/977#note_533871369

I can change the default to RHEL. However, I'm not sure anyone is still
able to build with rhel-8, because of the config options that require
gcc-plugin-devel + new GCC, last time I tried building on RHEL 8 I
couldn't due it. Unless the configs of gcc plugin struckleak were
reverted already, I don't remember that happening yet.

After installing some packages from fedora (bats, parallel), I did:
```
make dist-srpm
make dist-self-test
```
This is the result:
```
$ make dist-self-test
make -C redhat dist-self-test
make[1]: Entrando no diretório '/home/remote/hkrzesin/kernel-ark/redhat'

BUILDID is ".test".
 ✗ shellcheck
   (in test file self-test/0001-shellcheck.bats, line 7)
     `[ "$status" = 0 ]' failed
 ✓ Exactly one SRPM exists
 - rpmlint (skipped: Skip rpmlint test pending kernel.spec.template
changes)
 ✓ SRPM unpacks OK
 ✓ Linux tree unpacks OK
 ✓ Linux top level structural check
 ✓ Exactly one SRPM exists
 - rpminspect (skipped: The rpminspect package is not installed)
 ✓ dist-dump-variables v5.8
 ✓ dist-dump-variables v5.8-rc7
 ✓ dist-dump-variables v5.8-9-g565674d613d7
 ✓ dist-dump-variables v5.8-rc5-99-g25ccd24ffd91
 ✓ dist-release prologue
 ✓ dist-release test 1
 ✓ dist-release test 2
 ✓ dist-release test 3
 ✓ dist-release epilogue

17 tests, 1 failure, 2 skipped
```

The shellcheck failures does not seem related to my changes here:
```
`$ shellcheck $(find redhat -name "*.sh")

In redhat/generate_bls_conf.sh line 22:
# shellcheck will complain about bootprefix being referenced but not
assigned,
^-- SC1073: Couldn't parse this shellcheck directive. Fix to allow more
checks.
                 ^-- SC1072: Expected '=' after directive key. Fix any
mentioned problems and try again.


In redhat/genspec.sh line 17:
ZSTREAM_FLAG=${11}
^----------^ SC2034: ZSTREAM_FLAG appears unused. Verify use (or export
if used externally).


In redhat/genspec.sh line 51:
        ^master "$lasttag".. -- ':!/redhat/rhdocs' | ${0%/*}/genlog.py
>> "$clogf"
                                                     ^-----^ SC2086:
Double quote to prevent globbing and word splitting.

Did you mean:
        ^master "$lasttag".. -- ':!/redhat/rhdocs' | "${0%/*}"/genlog.py
>> "$clogf"


In redhat/dist-dump-variables.sh line 1:
echo "ARCH_LIST=$ARCH_LIST"
^-- SC2148: Tips depend on target shell and yours is unknown. Add a
shebang or a 'shell' directive.

For more information:
  https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell
and y...
  https://www.shellcheck.net/wiki/SC2034 -- ZSTREAM_FLAG appears unused.
Veri...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent
globbing ...``

```
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux