Re: [OS-BUILD PATCH] [redhat] New configs in drivers/pinctrl

David Arcari <darcari@xxxxxxxxxx> · Mon, 21 Dec 2020 07:57:41 -0500

On 12/18/20 2:33 AM, GitLab Bridge on behalf of redhat-patchlab wrote:
From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx>

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

  CONFIG_PINCTRL_ALDERLAKE:

  This pinctrl driver provides an interface that allows configuring
  of Intel Alder Lake PCH pins and using them as GPIOs.

  Symbol: PINCTRL_ALDERLAKE [=n]
  Type  : tristate
  Defined at drivers/pinctrl/intel/Kconfig:58
    Prompt: Intel Alder Lake pinctrl and GPIO driver
    Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
    Location:
      -> Device Drivers
        -> Pin controllers (PINCTRL [=y])
  Selects: PINCTRL_INTEL [=y]

---

  CONFIG_PINCTRL_ELKHARTLAKE:

  This pinctrl driver provides an interface that allows configuring
  of Intel Elkhart Lake SoC pins and using them as GPIOs.

  Symbol: PINCTRL_ELKHARTLAKE [=n]
  Type  : tristate
  Defined at drivers/pinctrl/intel/Kconfig:98
    Prompt: Intel Elkhart Lake SoC pinctrl and GPIO driver
    Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
    Location:
      -> Device Drivers
        -> Pin controllers (PINCTRL [=y])
  Selects: PINCTRL_INTEL [=y]

---

  CONFIG_PINCTRL_LAKEFIELD:

  This pinctrl driver provides an interface that allows configuring
  of Intel Lakefield SoC pins and using them as GPIOs.

  Symbol: PINCTRL_LAKEFIELD [=n]
  Type  : tristate
  Defined at drivers/pinctrl/intel/Kconfig:138
    Prompt: Intel Lakefield SoC pinctrl and GPIO driver
    Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
    Location:
      -> Device Drivers
        -> Pin controllers (PINCTRL [=y])
  Selects: PINCTRL_INTEL [=y]

---

  CONFIG_PINCTRL_LPASS_LPI:

  This is the pinctrl, pinmux, pinconf and gpiolib driver for the
  Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI
  (Low Power Island) found on the Qualcomm Technologies Inc SoCs.

  Symbol: PINCTRL_LPASS_LPI [=n]
  Type  : tristate
  Defined at drivers/pinctrl/qcom/Kconfig:268
    Prompt: Qualcomm Technologies Inc LPASS LPI pin controller driver
    Depends on: PINCTRL [=y] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && GPIOLIB [=y]
    Location:
      -> Device Drivers
        -> Pin controllers (PINCTRL [=y])
  Selects: PINMUX [=n] && PINCONF [=y] && GENERIC_PINCONF [=y]

---

  CONFIG_PINCTRL_MICROCHIP_SGPIO:

  Support for the serial GPIO interface used on Microsemi and
  Microchip SoC's. By using a serial interface, the SIO
  controller significantly extends the number of available
  GPIOs with a minimum number of additional pins on the
  device. The primary purpose of the SIO controller is to
  connect control signals from SFP modules and to act as an
  LED controller.

  Symbol: PINCTRL_MICROCHIP_SGPIO [=n]
  Type  : bool
  Defined at drivers/pinctrl/Kconfig:378
    Prompt: Pinctrl driver for Microsemi/Microchip Serial GPIO
    Depends on: PINCTRL [=y] && OF [=y] && HAS_IOMEM [=y]
    Location:
      -> Device Drivers
        -> Pin controllers (PINCTRL [=y])
  Selects: GPIOLIB [=y] && GPIOLIB_IRQCHIP [=y] && GENERIC_PINCONF [=y] && GENERIC_PINCTRL_GROUPS [=n] && GENERIC_PINMUX_FUNCTIONS [=n] && OF_GPIO [=y]

---

Cc: Brian Masney <bmasney@xxxxxxxxxx>
Cc: David Arcari <darcari@xxxxxxxxxx>
Signed-off-by: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx>
---
  .../common/generic/CONFIG_PINCTRL_ALDERLAKE   |  1 +
  .../common/generic/CONFIG_PINCTRL_ELKHARTLAKE |  1 +
  .../common/generic/CONFIG_PINCTRL_LAKEFIELD   |  1 +
  .../common/generic/CONFIG_PINCTRL_LPASS_LPI   |  1 +
  .../generic/CONFIG_PINCTRL_MICROCHIP_SGPIO    |  1 +
  .../generic/CONFIG_PINCTRL_ALDERLAKE          | 18 ---------------
  .../generic/CONFIG_PINCTRL_ELKHARTLAKE        | 18 ---------------
  .../generic/CONFIG_PINCTRL_LAKEFIELD          | 18 ---------------
  .../generic/CONFIG_PINCTRL_LPASS_LPI          | 19 ---------------
  .../generic/CONFIG_PINCTRL_MICROCHIP_SGPIO    | 23 -------------------
  10 files changed, 5 insertions(+), 96 deletions(-)
  create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_ALDERLAKE
  create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_ELKHARTLAKE
  create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_LAKEFIELD
  create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_LPASS_LPI
  create mode 100644 redhat/configs/common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO
  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_ALDERLAKE
  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_ELKHARTLAKE
  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_LAKEFIELD
  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_LPASS_LPI
  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO

diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_ALDERLAKE b/redhat/configs/common/generic/CONFIG_PINCTRL_ALDERLAKE
new file mode 100644
index 000000000000..fc34a4ac0016
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_ALDERLAKE
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_ALDERLAKE is not set

We want this one set:

CONFIG_PINCTRL_ALDERLAKE=m

diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_ELKHARTLAKE b/redhat/configs/common/generic/CONFIG_PINCTRL_ELKHARTLAKE
new file mode 100644
index 000000000000..224fd47cc178
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_ELKHARTLAKE
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_ELKHARTLAKE is not set

We also want this one set:

CONFIG_PINCTRL_ELKHARTLAKE=m

diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_LAKEFIELD b/redhat/configs/common/generic/CONFIG_PINCTRL_LAKEFIELD
new file mode 100644
index 000000000000..7333be215f28
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_LAKEFIELD
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_LAKEFIELD is not set

And finally we want this one set:

CONFIG_PINCTRL_LAKEFIELD=m

Thanks,

-DA

diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_LPASS_LPI b/redhat/configs/common/generic/CONFIG_PINCTRL_LPASS_LPI
new file mode 100644
index 000000000000..e76dab69c9e3
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_LPASS_LPI
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_LPASS_LPI is not set
diff --git a/redhat/configs/common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO b/redhat/configs/common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO
new file mode 100644
index 000000000000..e8878348968c
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO
@@ -0,0 +1 @@
+# CONFIG_PINCTRL_MICROCHIP_SGPIO is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_ALDERLAKE b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_ALDERLAKE
deleted file mode 100644
index 1567248f6edf..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_ALDERLAKE
+++ /dev/null
@@ -1,18 +0,0 @@
-# CONFIG_PINCTRL_ALDERLAKE:
-#
-# This pinctrl driver provides an interface that allows configuring
-# of Intel Alder Lake PCH pins and using them as GPIOs.
-#
-# Symbol: PINCTRL_ALDERLAKE [=n]
-# Type  : tristate
-# Defined at drivers/pinctrl/intel/Kconfig:58
-#   Prompt: Intel Alder Lake pinctrl and GPIO driver
-#   Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Pin controllers (PINCTRL [=y])
-# Selects: PINCTRL_INTEL [=y]
-#
-#
-#
-# CONFIG_PINCTRL_ALDERLAKE is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_ELKHARTLAKE b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_ELKHARTLAKE
deleted file mode 100644
index 8b11d54ed53c..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_ELKHARTLAKE
+++ /dev/null
@@ -1,18 +0,0 @@
-# CONFIG_PINCTRL_ELKHARTLAKE:
-#
-# This pinctrl driver provides an interface that allows configuring
-# of Intel Elkhart Lake SoC pins and using them as GPIOs.
-#
-# Symbol: PINCTRL_ELKHARTLAKE [=n]
-# Type  : tristate
-# Defined at drivers/pinctrl/intel/Kconfig:98
-#   Prompt: Intel Elkhart Lake SoC pinctrl and GPIO driver
-#   Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Pin controllers (PINCTRL [=y])
-# Selects: PINCTRL_INTEL [=y]
-#
-#
-#
-# CONFIG_PINCTRL_ELKHARTLAKE is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_LAKEFIELD b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_LAKEFIELD
deleted file mode 100644
index 11c16fb63c57..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_LAKEFIELD
+++ /dev/null
@@ -1,18 +0,0 @@
-# CONFIG_PINCTRL_LAKEFIELD:
-#
-# This pinctrl driver provides an interface that allows configuring
-# of Intel Lakefield SoC pins and using them as GPIOs.
-#
-# Symbol: PINCTRL_LAKEFIELD [=n]
-# Type  : tristate
-# Defined at drivers/pinctrl/intel/Kconfig:138
-#   Prompt: Intel Lakefield SoC pinctrl and GPIO driver
-#   Depends on: PINCTRL [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Pin controllers (PINCTRL [=y])
-# Selects: PINCTRL_INTEL [=y]
-#
-#
-#
-# CONFIG_PINCTRL_LAKEFIELD is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_LPASS_LPI b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_LPASS_LPI
deleted file mode 100644
index 7dd5771c745c..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_LPASS_LPI
+++ /dev/null
@@ -1,19 +0,0 @@
-# CONFIG_PINCTRL_LPASS_LPI:
-#
-# This is the pinctrl, pinmux, pinconf and gpiolib driver for the
-# Qualcomm Technologies Inc LPASS (Low Power Audio SubSystem) LPI
-# (Low Power Island) found on the Qualcomm Technologies Inc SoCs.
-#
-# Symbol: PINCTRL_LPASS_LPI [=n]
-# Type  : tristate
-# Defined at drivers/pinctrl/qcom/Kconfig:268
-#   Prompt: Qualcomm Technologies Inc LPASS LPI pin controller driver
-#   Depends on: PINCTRL [=y] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && GPIOLIB [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Pin controllers (PINCTRL [=y])
-# Selects: PINMUX [=n] && PINCONF [=y] && GENERIC_PINCONF [=y]
-#
-#
-#
-# CONFIG_PINCTRL_LPASS_LPI is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO b/redhat/configs/pending-common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO
deleted file mode 100644
index 68c53a636d99..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_PINCTRL_MICROCHIP_SGPIO
+++ /dev/null
@@ -1,23 +0,0 @@
-# CONFIG_PINCTRL_MICROCHIP_SGPIO:
-#
-# Support for the serial GPIO interface used on Microsemi and
-# Microchip SoC's. By using a serial interface, the SIO
-# controller significantly extends the number of available
-# GPIOs with a minimum number of additional pins on the
-# device. The primary purpose of the SIO controller is to
-# connect control signals from SFP modules and to act as an
-# LED controller.
-#
-# Symbol: PINCTRL_MICROCHIP_SGPIO [=n]
-# Type  : bool
-# Defined at drivers/pinctrl/Kconfig:378
-#   Prompt: Pinctrl driver for Microsemi/Microchip Serial GPIO
-#   Depends on: PINCTRL [=y] && OF [=y] && HAS_IOMEM [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Pin controllers (PINCTRL [=y])
-# Selects: GPIOLIB [=y] && GPIOLIB_IRQCHIP [=y] && GENERIC_PINCONF [=y] && GENERIC_PINCTRL_GROUPS [=n] && GENERIC_PINMUX_FUNCTIONS [=n] && OF_GPIO [=y]
-#
-#
-#
-# CONFIG_PINCTRL_MICROCHIP_SGPIO is not set

_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx







