From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> Hi, As part of the ongoing rebase effort, the following configuration options need to be reviewed. As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy. If the value for a file that is added should be changed, please reply with a better option. CONFIG_FTRACE_RECORD_RECURSION: All callbacks that attach to the function tracing have some sort of protection against recursion. Even though the protection exists, it adds overhead. This option will create a file in the tracefs file system called "recursed_functions" that will list the functions that triggered a recursion. This will add more overhead to cases that have recursion. If unsure, say N Symbol: FTRACE_RECORD_RECURSION [=n] Type : bool Defined at kernel/trace/Kconfig:737 Prompt: Record functions that recurse in function tracing Depends on: TRACING_SUPPORT [=y] && FTRACE [=y] && FUNCTION_TRACER [=y] Location: -> Kernel hacking -> Tracers (FTRACE [=y]) --- CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS: This will audit the time stamps on the ring buffer sub buffer to make sure that all the time deltas for the events on a sub buffer matches the current time stamp. This audit is performed for every event that is not interrupted, or interrupting another event. A check is also made when traversing sub buffers to make sure that all the deltas on the previous sub buffer do not add up to be greater than the current time stamp. NOTE: This adds significant overhead to recording of events, and should only be used to test the logic of the ring buffer. Do not use it on production systems. Only say Y if you understand what this does, and you still want it enabled. Otherwise say N Symbol: RING_BUFFER_VALIDATE_TIME_DELTAS [=n] Type : bool Defined at kernel/trace/Kconfig:846 Prompt: Verify ring buffer time stamp deltas Depends on: TRACING_SUPPORT [=y] && FTRACE [=y] && RING_BUFFER [=y] Location: -> Kernel hacking -> Tracers (FTRACE [=y]) --- Cc: Jerome Marchand <jmarchan@xxxxxxxxxx> Signed-off-by: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> --- .../generic/CONFIG_FTRACE_RECORD_RECURSION | 1 + .../CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS | 1 + .../generic/CONFIG_FTRACE_RECORD_RECURSION | 24 --------------- .../CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS | 30 ------------------- 4 files changed, 2 insertions(+), 54 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_FTRACE_RECORD_RECURSION create mode 100644 redhat/configs/common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS delete mode 100644 redhat/configs/pending-common/generic/CONFIG_FTRACE_RECORD_RECURSION delete mode 100644 redhat/configs/pending-common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS diff --git a/redhat/configs/common/generic/CONFIG_FTRACE_RECORD_RECURSION b/redhat/configs/common/generic/CONFIG_FTRACE_RECORD_RECURSION new file mode 100644 index 000000000000..613dd9d01aef --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_FTRACE_RECORD_RECURSION @@ -0,0 +1 @@ +# CONFIG_FTRACE_RECORD_RECURSION is not set diff --git a/redhat/configs/common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS b/redhat/configs/common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS new file mode 100644 index 000000000000..062dee43468f --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS @@ -0,0 +1 @@ +# CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_FTRACE_RECORD_RECURSION b/redhat/configs/pending-common/generic/CONFIG_FTRACE_RECORD_RECURSION deleted file mode 100644 index d4b4d5a8a0da..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_FTRACE_RECORD_RECURSION +++ /dev/null @@ -1,24 +0,0 @@ -# CONFIG_FTRACE_RECORD_RECURSION: -# -# All callbacks that attach to the function tracing have some sort -# of protection against recursion. Even though the protection exists, -# it adds overhead. This option will create a file in the tracefs -# file system called "recursed_functions" that will list the functions -# that triggered a recursion. -# -# This will add more overhead to cases that have recursion. -# -# If unsure, say N -# -# Symbol: FTRACE_RECORD_RECURSION [=n] -# Type : bool -# Defined at kernel/trace/Kconfig:737 -# Prompt: Record functions that recurse in function tracing -# Depends on: TRACING_SUPPORT [=y] && FTRACE [=y] && FUNCTION_TRACER [=y] -# Location: -# -> Kernel hacking -# -> Tracers (FTRACE [=y]) -# -# -# -# CONFIG_FTRACE_RECORD_RECURSION is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS b/redhat/configs/pending-common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS deleted file mode 100644 index 383636599d30..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS +++ /dev/null @@ -1,30 +0,0 @@ -# CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS: -# -# This will audit the time stamps on the ring buffer sub -# buffer to make sure that all the time deltas for the -# events on a sub buffer matches the current time stamp. -# This audit is performed for every event that is not -# interrupted, or interrupting another event. A check -# is also made when traversing sub buffers to make sure -# that all the deltas on the previous sub buffer do not -# add up to be greater than the current time stamp. -# -# NOTE: This adds significant overhead to recording of events, -# and should only be used to test the logic of the ring buffer. -# Do not use it on production systems. -# -# Only say Y if you understand what this does, and you -# still want it enabled. Otherwise say N -# -# Symbol: RING_BUFFER_VALIDATE_TIME_DELTAS [=n] -# Type : bool -# Defined at kernel/trace/Kconfig:846 -# Prompt: Verify ring buffer time stamp deltas -# Depends on: TRACING_SUPPORT [=y] && FTRACE [=y] && RING_BUFFER [=y] -# Location: -# -> Kernel hacking -# -> Tracers (FTRACE [=y]) -# -# -# -# CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS is not set -- GitLab _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx