Re: [OS-BUILD PATCHv3 0/3] [redhat] New configs in drivers/i2c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/7/20 10:32 AM, GitLab Bridge on behalf of jeremycline wrote:
From: jeremycline on gitlab.com

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

  CONFIG_I2C_MLXBF:

  Enabling this option will add I2C SMBus support for Mellanox BlueField
  system.

  This driver can also be built as a module. If so, the module will be
  called i2c-mlxbf.

  This driver implements an I2C SMBus host controller and enables both
  master and slave functions.

  Symbol: I2C_MLXBF [=n]
  Type  : tristate
  Defined at drivers/i2c/busses/Kconfig:734
    Prompt: Mellanox BlueField I2C controller
    Depends on: I2C [=y] && HAS_IOMEM [=y] && ARM64 [=y]
    Location:
      -> Device Drivers
        -> I2C support
          -> I2C support (I2C [=y])
            -> I2C Hardware Bus support

---

  CONFIG_I2C_SLAVE_TESTUNIT:

  This backend can be used to trigger test cases for I2C bus masters
  which require a remote device with certain capabilities, e.g.
  multi-master, SMBus Host Notify, etc. Please read
  Documentation/i2c/slave-testunit-backend.rst for further details.

  Symbol: I2C_SLAVE_TESTUNIT [=n]
  Type  : tristate
  Defined at drivers/i2c/Kconfig:128
    Prompt: I2C eeprom testunit driver
    Depends on: I2C [=y] && I2C_SLAVE [=y]
    Location:
      -> Device Drivers
        -> I2C support
          -> I2C support (I2C [=y])
            -> I2C slave support (I2C_SLAVE [=y])

---

Cc: Gopal Tiwari <gtiwari@xxxxxxxxxx>
Cc: David Arcari <darcari@xxxxxxxxxx>
Signed-off-by: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx>



Hi,

This patchset seems a little obtuse to me. As far as I can tell this should just be one single patch - not a 3 part series, but perhaps I am missing something.

In the interim, politely,

Nacked-by: David Arcari <darcari@xxxxxxxxxx>

-DA


_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux