[OS-BUILD PATCHv2 16/20] [redhat] merge-subtrees.sh: Fix syntax flagged by shellcheck

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Ben Crocker <bcrocker@xxxxxxxxxx>

SC2162: read without -r will mangle backslashes
SC2086: Double quote to prevent globbing and word splitting

Rewrote main loop so it will work.

Signed-off-by: Ben Crocker <bcrocker@xxxxxxxxxx>

merge-subtrees.h: fix

Signed-off-by: Ben Crocker <bcrocker@xxxxxxxxxx>
---
 redhat/scripts/merge-subtrees.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/redhat/scripts/merge-subtrees.sh b/redhat/scripts/merge-subtrees.sh
index 02b8e8d37ff6..8dbf86400621 100755
--- a/redhat/scripts/merge-subtrees.sh
+++ b/redhat/scripts/merge-subtrees.sh
@@ -1,5 +1,4 @@
 #!/bin/sh
-
 # In newer versions of git-subtree the git repo is not explicitly required,
 # however, given the wide variance of git versions we need to include it.
 
@@ -7,6 +6,7 @@ entries="
 	redhat/rhdocs git://git.host.prod.eng.bos.redhat.com/rhkernel-docs
 	"
 
-echo $entries | while read entry; do
-	git subtree pull --prefix=$entry  master
+echo "$entries" | while read -r name url; do
+	[ -z "$name" ] && continue
+	git subtree pull --prefix="$name" "$url"  master
 done
-- 
GitLab
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux