On Fri, 13 Nov 2020 21:12:20 -0000, GitLab Bridge on behalf of bcrocker wrote: > #!/bin/bash > -if [ -z "$1" -o -z "$2" ]; then > - echo "$(basename $0) <redhat path> <zstream? no/yes/branch>" >&2; > +if [ -z "$1" ] || [ -z "$2" ]; then if [[ -z $1 || -z $2 ]] More readable, no quotes needed, etc. This is bash anyway, so why to go through hoops of accommodating how different shells interpret POSIX? Jiri _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx