Re: [OS-BUILD PATCHv6 0/8] [redhat] Add GIT macro to Makefile and Makefile.common:

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 13, 2020 at 09:11:36PM -0000, GitLab Bridge on behalf of bcrocker wrote:
> From: bcrocker on gitlab.com
> 
> Add a GIT macro to Makefile:
> 
> GIT ?= git
> 
> and replace literal occurrences of 'git' with $(GIT)\
> in Makefile and Makefile.common.
> 
> This change enables us to override 'git' with, e.g., some\
> arbitrary shell script that prints additional information\
> and/or does additional processing before and/or after (or\
> even instead of) invoking /usr/bin/git.

Hi Ben,

Is there anyway you can combine parts of patch 4 and 5 into patch 3?  It
seems odd to see the history of the code in the patches like that.

Also you mentioned the rpmlint and rpminspect are not successful on
invocation, but they still seemed wired up to make dist-self-tests.  I would
like to make sure 'make dist-self-tests' is always successful.

You can keep the rpmlint and rpminspect code in there, just disable it and
put a comment that there is work to do before it passes and can be
re-enabled.

Thoughts?

Cheers,
Don
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux