[OS-BUILD PATCH 9/20] [redhat] generate_bls_conf.sh: Fix syntax flagged by shellcheck

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Ben Crocker <bcrocker@xxxxxxxxxx>

SC2086: Double quote to prevent globbing and word splitting.

Ignoring:
SC1091: Not following: /etc/os-release was not specified as input (see shellcheck -x).
SC2154: bootprefix is referenced but not assigned.
We are generating, e.g., /lib/modules/<kernel>/bls.conf;
bootprefix may legitimately be undefined here in this script.

Signed-off-by: Ben Crocker <bcrocker@xxxxxxxxxx>
---
 redhat/generate_bls_conf.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/redhat/generate_bls_conf.sh b/redhat/generate_bls_conf.sh
index f8415db245f4..27a86cecff42 100755
--- a/redhat/generate_bls_conf.sh
+++ b/redhat/generate_bls_conf.sh
@@ -1,6 +1,7 @@
 #!/bin/bash
 set -e
 
+# shellcheck disable=SC1091
 . /etc/os-release
 
 kernelver=$1 && shift
@@ -18,7 +19,10 @@ else
     debugid=""
 fi
 
-cat >${output} <<EOF
+# We are generating, e.g., /lib/modules/<kernel>/bls.conf;
+# bootprefix may legitimately be undefined here in this script:
+# shellcheck disable=SC2154
+cat > "$output" <<EOF
 title ${NAME} (${kernelver}) ${VERSION}${debugname}
 version ${kernelver}${debugid}
 linux ${bootprefix}/vmlinuz-${kernelver}
-- 
GitLab
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux