On Tue, Oct 27, 2020 at 11:13:40PM -0000, GitLab Bridge on behalf of jeremycline wrote: > From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> > > Hi, > > As part of the ongoing rebase effort, the following configuration > options need to be reviewed. > > As a reminder, the ARK configuration flow involves moving unreviewed > configuration options from the pending directory to the ark directory. > In the diff below, options are removed from the pending directory and > added to the ark hierarchy. The final options that need to be ACKed > are the files that are being added to the ark hierarchy. > > If the value for a file that is added should be changed, please reply > with a better option. > > CONFIG_GPIO_CDEV_V1: > > Say Y here to support version 1 of the GPIO CDEV ABI. > > This ABI version is deprecated. > Please use the latest ABI for new developments. > > If unsure, say Y. > > Symbol: GPIO_CDEV_V1 [=y] > Type : bool > Defined at drivers/gpio/Kconfig:85 > Prompt: Support GPIO ABI Version 1 > Depends on: GPIOLIB [=y] && GPIO_CDEV [=y] > Location: > -> Device Drivers > -> GPIO Support (GPIOLIB [=y]) > -> Character device (/dev/gpiochipN) support (GPIO_CDEV [=y]) > > Cc: Brian Masney <bmasney@xxxxxxxxxx> > Cc: David Arcari <darcari@xxxxxxxxxx> > --- > .../common/generic/CONFIG_GPIO_CDEV_V1 | 1 + > .../generic/CONFIG_GPIO_CDEV_V1 | 22 ------------------- > 2 files changed, 1 insertion(+), 22 deletions(-) > create mode 100644 redhat/configs/common/generic/CONFIG_GPIO_CDEV_V1 > delete mode 100644 redhat/configs/pending-common/generic/CONFIG_GPIO_CDEV_V1 > > diff --git a/redhat/configs/common/generic/CONFIG_GPIO_CDEV_V1 b/redhat/configs/common/generic/CONFIG_GPIO_CDEV_V1 > new file mode 100644 > index 000000000000..2a4e60a576ae > --- /dev/null > +++ b/redhat/configs/common/generic/CONFIG_GPIO_CDEV_V1 > @@ -0,0 +1 @@ > +CONFIG_GPIO_CDEV_V1=y I think we should disable this in ARK since there's some alignment issues when running 32-bit apps on 64-bit kernels with the v1 ABI that's described at [1]. libgpiod [2] has been updated to use the v2 ABI and will require a 5.10 kernel for the v2 ABI. Leave it enabled in Fedora for now but we should consider disabling this for Fedora 34. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b53911aa872d [2] https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/ Brian _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
