Re: [OS-BUILD PATCH] [redhat] New configs in drivers/i2c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/22/20 2:37 AM, Gopal Tiwari wrote:
> CONFIG_I2C_SLAVE_TESTUNIT : This looks promising to me. I think enabling this is no harm. But leaving it for now.
> 
> CONFIG_I2C_MLXBF : let's wait till we receive any request from partner or customer. 
> 
> Would think to enable CONFIG_I2C_SLAVE_TESTUNIT in future. I am fine with the configuration for now. Unless David Arcari thinks otherwise. 

No - I think it looks good as is.  BTW CONFIG_I2C_SLAVE is only set on aarch64,
so if CONFIG_I2C_SLAVE_TESTUNIT were enabled it would only impact arm.

Acked-by: David Arcari <darcari@xxxxxxxxxx>

> 
> Acked-by: Gopal Tiwari <gtiwari@xxxxxxxxxx> 
> 
> Thanks & regards,
> Gopal Tiwari 
> 
> ----- Original Message -----
> From: "GitLab Bridge on behalf of jeremycline" <cki-gitlab@xxxxxxxxxx>
> To: kernel@xxxxxxxxxxxxxxxxxxxxxxx
> Cc: darcari@xxxxxxxxxx, gtiwari@xxxxxxxxxx, kernel-team@xxxxxxxxxxxxxxxxx
> Sent: Thursday, October 22, 2020 11:55:24 AM
> Subject: [OS-BUILD PATCH] [redhat] New configs in drivers/i2c
> 
> From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx>
> 
> Hi,
> 
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
> 
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
> 
> If the value for a file that is added should be changed, please reply
> with a better option.
> 
>  CONFIG_I2C_MLXBF:
> 
>  Enabling this option will add I2C SMBus support for Mellanox BlueField
>  system.
> 
>  This driver can also be built as a module. If so, the module will be
>  called i2c-mlxbf.
> 
>  This driver implements an I2C SMBus host controller and enables both
>  master and slave functions.
> 
>  Symbol: I2C_MLXBF [=n]
>  Type  : tristate
>  Defined at drivers/i2c/busses/Kconfig:734
>    Prompt: Mellanox BlueField I2C controller
>    Depends on: I2C [=y] && HAS_IOMEM [=y] && ARM64 [=y]
>    Location:
>      -> Device Drivers
>        -> I2C support
>          -> I2C support (I2C [=y])
>            -> I2C Hardware Bus support
> 
> ---
> 
>  CONFIG_I2C_SLAVE_TESTUNIT:
> 
>  This backend can be used to trigger test cases for I2C bus masters
>  which require a remote device with certain capabilities, e.g.
>  multi-master, SMBus Host Notify, etc. Please read
>  Documentation/i2c/slave-testunit-backend.rst for further details.
> 
>  Symbol: I2C_SLAVE_TESTUNIT [=n]
>  Type  : tristate
>  Defined at drivers/i2c/Kconfig:128
>    Prompt: I2C eeprom testunit driver
>    Depends on: I2C [=y] && I2C_SLAVE [=y]
>    Location:
>      -> Device Drivers
>        -> I2C support
>          -> I2C support (I2C [=y])
>            -> I2C slave support (I2C_SLAVE [=y])
> 
> ---
> 
> Cc: Gopal Tiwari <gtiwari@xxxxxxxxxx>
> Cc: David Arcari <darcari@xxxxxxxxxx>
> Signed-off-by: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx>
> ---
>  .../configs/common/generic/CONFIG_I2C_MLXBF   |  1 +
>  .../common/generic/CONFIG_I2C_SLAVE_TESTUNIT  |  1 +
>  .../pending-common/generic/CONFIG_I2C_MLXBF   | 25 -------------------
>  .../generic/CONFIG_I2C_SLAVE_TESTUNIT         | 21 ----------------
>  4 files changed, 2 insertions(+), 46 deletions(-)
>  create mode 100644 redhat/configs/common/generic/CONFIG_I2C_MLXBF
>  create mode 100644 redhat/configs/common/generic/CONFIG_I2C_SLAVE_TESTUNIT
>  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_I2C_MLXBF
>  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_I2C_SLAVE_TESTUNIT
> 
> diff --git a/redhat/configs/common/generic/CONFIG_I2C_MLXBF b/redhat/configs/common/generic/CONFIG_I2C_MLXBF
> new file mode 100644
> index 000000000000..185c147d7a58
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_I2C_MLXBF
> @@ -0,0 +1 @@
> +# CONFIG_I2C_MLXBF is not set
> diff --git a/redhat/configs/common/generic/CONFIG_I2C_SLAVE_TESTUNIT b/redhat/configs/common/generic/CONFIG_I2C_SLAVE_TESTUNIT
> new file mode 100644
> index 000000000000..14e66f89c8a8
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_I2C_SLAVE_TESTUNIT
> @@ -0,0 +1 @@
> +# CONFIG_I2C_SLAVE_TESTUNIT is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_I2C_MLXBF b/redhat/configs/pending-common/generic/CONFIG_I2C_MLXBF
> deleted file mode 100644
> index 4afff78d4142..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_I2C_MLXBF
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -# CONFIG_I2C_MLXBF:
> -# 
> -# Enabling this option will add I2C SMBus support for Mellanox BlueField
> -# system.
> -# 
> -# This driver can also be built as a module. If so, the module will be
> -# called i2c-mlxbf.
> -# 
> -# This driver implements an I2C SMBus host controller and enables both
> -# master and slave functions.
> -# 
> -# Symbol: I2C_MLXBF [=n]
> -# Type  : tristate
> -# Defined at drivers/i2c/busses/Kconfig:734
> -#   Prompt: Mellanox BlueField I2C controller
> -#   Depends on: I2C [=y] && HAS_IOMEM [=y] && ARM64 [=y]
> -#   Location:
> -#     -> Device Drivers
> -#       -> I2C support
> -#         -> I2C support (I2C [=y])
> -#           -> I2C Hardware Bus support
> -# 
> -# 
> -# 
> -# CONFIG_I2C_MLXBF is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_I2C_SLAVE_TESTUNIT b/redhat/configs/pending-common/generic/CONFIG_I2C_SLAVE_TESTUNIT
> deleted file mode 100644
> index dc55205cb13d..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_I2C_SLAVE_TESTUNIT
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -# CONFIG_I2C_SLAVE_TESTUNIT:
> -# 
> -# This backend can be used to trigger test cases for I2C bus masters
> -# which require a remote device with certain capabilities, e.g.
> -# multi-master, SMBus Host Notify, etc. Please read
> -# Documentation/i2c/slave-testunit-backend.rst for further details.
> -# 
> -# Symbol: I2C_SLAVE_TESTUNIT [=n]
> -# Type  : tristate
> -# Defined at drivers/i2c/Kconfig:128
> -#   Prompt: I2C eeprom testunit driver
> -#   Depends on: I2C [=y] && I2C_SLAVE [=y]
> -#   Location:
> -#     -> Device Drivers
> -#       -> I2C support
> -#         -> I2C support (I2C [=y])
> -#           -> I2C slave support (I2C_SLAVE [=y])
> -# 
> -# 
> -# 
> -# CONFIG_I2C_SLAVE_TESTUNIT is not set
> 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux