Re: [OS-BUILD PATCHv2] New configs in drivers/firmware

[Lenny Szubowicz <lszubowi@xxxxxxxxxx>]

On 10/21/20 1:47 PM, GitLab Bridge on behalf of jeremycline wrote:
> From: "CKI@GitLab" <CKI@GitLab>
>
> Hi,
>
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
>
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
>
> If the value for a file that is added should be changed, please reply
> with a better option.
>
>   CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER:
>
>   Select this config option to add support for the initrd= command
>   line parameter, allowing an initrd that resides on the same volume
>   as the kernel image to be loaded into memory.
>
>   This method is deprecated.
>
>   Symbol: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER [=y]
>   Type  : bool
>   Defined at drivers/firmware/efi/Kconfig:127
>     Prompt: Enable the command line initrd loader
>     Depends on: EFI [=y] && EFI_STUB [=y] && (EFI_GENERIC_STUB [=y] || X86)
>     Visible if: EFI [=y] && EFI_STUB [=y] && (EFI_GENERIC_STUB [=y] || X86) && !X86
>     Location:
>       -> Firmware Drivers
>         -> EFI (Extensible Firmware Interface) Support
>
> Cc: Lenny Szubowicz <lszubowi@xxxxxxxxxx>
> Cc: David Arcari <darcari@xxxxxxxxxx>
> Cc: Mark Langsdorf <mlangsdo@xxxxxxxxxx>
> ---
>   ...FIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER |  1 +
>   ...FIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER | 21 -------------------
>   2 files changed, 1 insertion(+), 21 deletions(-)
>   create mode 100644 redhat/configs/common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
>   delete mode 100644 redhat/configs/pending-common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
>
> diff --git a/redhat/configs/common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER b/redhat/configs/common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
> new file mode 100644
> index 000000000000..4fe880aee260
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
> @@ -0,0 +1 @@
> +CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER=y
> diff --git a/redhat/configs/pending-common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER b/redhat/configs/pending-common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
> deleted file mode 100644
> index 5c373663fb84..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -# CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER:
> -#
> -# Select this config option to add support for the initrd= command
> -# line parameter, allowing an initrd that resides on the same volume
> -# as the kernel image to be loaded into memory.
> -#
> -# This method is deprecated.
> -#
> -# Symbol: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER [=y]
> -# Type  : bool
> -# Defined at drivers/firmware/efi/Kconfig:127
> -#   Prompt: Enable the command line initrd loader
> -#   Depends on: EFI [=y] && EFI_STUB [=y] && (EFI_GENERIC_STUB [=y] || X86)
> -#   Visible if: EFI [=y] && EFI_STUB [=y] && (EFI_GENERIC_STUB [=y] || X86) && !X86
> -#   Location:
> -#     -> Firmware Drivers
> -#       -> EFI (Extensible Firmware Interface) Support
> -#
> -#
> -#
> -CONFIG_EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER=y

If you remove this config option, then I don't think it will be possible to boot the
kernel directly from the EFI shell anymore without the use of grub (or some other boot
loader) to load the initrd.

Admittedly, this is a pretty esoteric feature that is useful in highly unusual
situations, e.g. where grub is broken and the kernel and initrd are accessible from the
EFI shell. (I wonder if this is ever used in conjunction with OVMF/QEMU.)

This option is currently enabled in Fedora 33.

Are you removing it because of the comment about it being deprecated?

                          -Lenny.
  
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx