On Mon, Oct 19, 2020 at 06:36:45PM +0100, Peter Robinson wrote: > On Mon, Oct 19, 2020 at 6:29 PM Marcelo Ricardo Leitner > <mleitner@xxxxxxxxxx> wrote: > > > > On Mon, Oct 19, 2020 at 06:19:39PM +0100, Peter Robinson wrote: > > > On Mon, Oct 19, 2020 at 5:33 PM Marcelo Ricardo Leitner > > > <mleitner@xxxxxxxxxx> wrote: > > > > > > > > On Fri, Oct 16, 2020 at 03:29:56PM -0000, GitLab Bridge on behalf of jeremycline wrote: > > > > > --- /dev/null > > > > > +++ b/redhat/configs/common/generic/CONFIG_CAN_ISOTP > > > > > @@ -0,0 +1 @@ > > > > > +# CONFIG_CAN_ISOTP is not set > > > > > > > > I'm not aware of any reason for it to be enabled, so > > > > > > Reading the description [1] if CAN is enabled you likely do want to > > > enable it as it enables the ability to segment up packages to support > > > protocols like IP over CAN. > > > > This "likely" varies. I understand that it adds functionality, yes, > > but enabling it means extra work to support it and I'm not aware of > > any use case for it with RHEL. For Fedora that may be a different > > story, but then I expect someone more Fedora-centric to chime in. > > I think it should be reviewed for RHEL, the RHEL for Edge initiative > has CAN on it's roadmap amongst other things in the el9 timeframe. If Please share (off-list) some points on that. I'm all ears. > you''re enabling CAN it should be functional for the majority of > useful usecases or just disable it completely. Uhh.. so a new feature suddenly covers the majority of the useful usecases? For those you care about, maybe yes, but please don't ignore the rest. Anyhow, please share the use cases you're seeing. Maybe it should be enabled, yes, but we can't enable it just because it looks nice and adds extra functionality, that may or may not be used. The enablement doesn't end with turning this option on and more work is likely needed. For instance, we have 0 test coverage for this feature now. Marcelo _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
