Re: [OS-BUILD PATCH 1/3] redhat/Makefile: Fix '*-configs' targets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 24, 2020 at 04:03:27PM -0400, Prarit Bhargava wrote:
> On 8/24/20 3:21 PM, Marcelo Ricardo Leitner wrote:
> > On Mon, Aug 24, 2020 at 03:15:44PM -0400, Don Zickus wrote:
> >> On Mon, Aug 24, 2020 at 03:24:28PM -0300, Marcelo Ricardo Leitner wrote:
> >>>
> >>> But yeah, some will complain that now they need to copy a different
> >>> file to import the .config, but at least they will be sure of what
> >>> they are copying.
> >>
> >> Ah ok, so both rhel and fedora was built, one was tossed and the resulting
> >> config files had the same name regardless which 'flavor' was choosen.  That
> >> is confusing.  We can/should fix that to be more clear.  Or I guess Prarit's
> >> patch does just that.  Thanks for pointing that out.
> > 
> > It doesn't. Not yet, at least. :-)
> > 
> 
> The behavior of dist-configs is the same before and after my patch.  I haven't
> done anything to change that behavior for fear of breaking something else.
> 
> FWIW, I don't want to change the behavior in this patchset.  It's just asking
> for more trouble.

Ok, I can agree with that, especially considering the changelog
states:
"""
- Fix dist-configs to use a specified flavor instead of only ELN.  By
  default, dist-configs will build ELN configs.
"""

Which is what it is doing right now, and leave the dist-config we
discussed for a follow-up patch, as it is likely to be more polemic.

  Marcelo
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux