On 8/12/20 8:57 PM, GitLab Bridge on behalf of jeremycline wrote: > From: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> > > Hi, > > As part of the ongoing rebase effort, the following configuration > options need to be reviewed. > > As a reminder, the ARK configuration flow involves moving unreviewed > configuration options from the pending directory to the ark directory. > In the diff below, options are removed from the pending directory and > added to the ark hierarchy. The final options that need to be ACKed > are the files that are being added to the ark hierarchy. > > If the value for a file that is added should be changed, please reply > with a better option. > > CONFIG_DEBUG_FS_ALLOW_ALL: > > No restrictions apply. Both API and filesystem registration > is on. This is the normal default operation. > > Symbol: DEBUG_FS_ALLOW_ALL [=y] > Type : bool > Defined at lib/Kconfig.debug:500 > Prompt: Access normal > Depends on: <choice> > Location: > -> Kernel hacking > -> Generic Kernel Debugging Instruments > -> Debug Filesystem (DEBUG_FS [=y]) > -> Debugfs default access (<choice> [=y]) > > --- > We want this ^^ to be 'y'. > CONFIG_DEBUG_FS_ALLOW_NONE: > > Access is off. Clients get -PERM when trying to create nodes in > debugfs tree and debugfs is not registered as a filesystem. > Client can then back-off or continue without debugfs access. > > Symbol: DEBUG_FS_ALLOW_NONE [=n] > Type : bool > Defined at lib/Kconfig.debug:513 > Prompt: No access > Depends on: <choice> > Location: > -> Kernel hacking > -> Generic Kernel Debugging Instruments > -> Debug Filesystem (DEBUG_FS [=y]) > -> Debugfs default access (<choice> [=y]) > > --- > > CONFIG_DEBUG_FS_DISALLOW_MOUNT: > > The API is open but filesystem is not loaded. Clients can still do > their work and read with debug tools that do not need > debugfs filesystem. > > Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] > Type : bool > Defined at lib/Kconfig.debug:506 > Prompt: Do not register debugfs as filesystem > Depends on: <choice> > Location: > -> Kernel hacking > -> Generic Kernel Debugging Instruments > -> Debug Filesystem (DEBUG_FS [=y]) > -> Debugfs default access (<choice> [=y]) > These last two should be 'is not set' on the base kernel, and 'y' on debug kernels. Nacked-by: Prarit Bhargava <prarit@xxxxxxxxxx> P. > --- > > Signed-off-by: Fedora Kernel Team <kernel-team@xxxxxxxxxxxxxxxxx> > --- > .../common/generic/CONFIG_DEBUG_FS_ALLOW_ALL | 1 + > .../common/generic/CONFIG_DEBUG_FS_ALLOW_NONE | 1 + > .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 1 + > .../generic/CONFIG_DEBUG_FS_ALLOW_ALL | 19 ------------------ > .../generic/CONFIG_DEBUG_FS_ALLOW_NONE | 20 ------------------- > .../generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT | 20 ------------------- > 6 files changed, 3 insertions(+), 59 deletions(-) > create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL > create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE > create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT > delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL > delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE > delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT > > diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL > new file mode 100644 > index 000000000000..69490c3a53d5 > --- /dev/null > +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_ALL > @@ -0,0 +1 @@ > +CONFIG_DEBUG_FS_ALLOW_ALL=y > diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE > new file mode 100644 > index 000000000000..2d2a249b14c9 > --- /dev/null > +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_ALLOW_NONE > @@ -0,0 +1 @@ > +# CONFIG_DEBUG_FS_ALLOW_NONE is not set > diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT > new file mode 100644 > index 000000000000..d70cb272a100 > --- /dev/null > +++ b/redhat/configs/common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT > @@ -0,0 +1 @@ > +# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set > diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL > deleted file mode 100644 > index 083ba7cb0dd7..000000000000 > --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_ALL > +++ /dev/null > @@ -1,19 +0,0 @@ > -# CONFIG_DEBUG_FS_ALLOW_ALL: > -# > -# No restrictions apply. Both API and filesystem registration > -# is on. This is the normal default operation. > -# > -# Symbol: DEBUG_FS_ALLOW_ALL [=y] > -# Type : bool > -# Defined at lib/Kconfig.debug:500 > -# Prompt: Access normal > -# Depends on: <choice> > -# Location: > -# -> Kernel hacking > -# -> Generic Kernel Debugging Instruments > -# -> Debug Filesystem (DEBUG_FS [=y]) > -# -> Debugfs default access (<choice> [=y]) > -# > -# > -# > -CONFIG_DEBUG_FS_ALLOW_ALL=y > diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE > deleted file mode 100644 > index f61111aac6c0..000000000000 > --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_ALLOW_NONE > +++ /dev/null > @@ -1,20 +0,0 @@ > -# CONFIG_DEBUG_FS_ALLOW_NONE: > -# > -# Access is off. Clients get -PERM when trying to create nodes in > -# debugfs tree and debugfs is not registered as a filesystem. > -# Client can then back-off or continue without debugfs access. > -# > -# Symbol: DEBUG_FS_ALLOW_NONE [=n] > -# Type : bool > -# Defined at lib/Kconfig.debug:513 > -# Prompt: No access > -# Depends on: <choice> > -# Location: > -# -> Kernel hacking > -# -> Generic Kernel Debugging Instruments > -# -> Debug Filesystem (DEBUG_FS [=y]) > -# -> Debugfs default access (<choice> [=y]) > -# > -# > -# > -# CONFIG_DEBUG_FS_ALLOW_NONE is not set > diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT b/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT > deleted file mode 100644 > index 270523a0536d..000000000000 > --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_FS_DISALLOW_MOUNT > +++ /dev/null > @@ -1,20 +0,0 @@ > -# CONFIG_DEBUG_FS_DISALLOW_MOUNT: > -# > -# The API is open but filesystem is not loaded. Clients can still do > -# their work and read with debug tools that do not need > -# debugfs filesystem. > -# > -# Symbol: DEBUG_FS_DISALLOW_MOUNT [=n] > -# Type : bool > -# Defined at lib/Kconfig.debug:506 > -# Prompt: Do not register debugfs as filesystem > -# Depends on: <choice> > -# Location: > -# -> Kernel hacking > -# -> Generic Kernel Debugging Instruments > -# -> Debug Filesystem (DEBUG_FS [=y]) > -# -> Debugfs default access (<choice> [=y]) > -# > -# > -# > -# CONFIG_DEBUG_FS_DISALLOW_MOUNT is not set > _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
