Re: [OS-BUILD PATCHv2] redhat/Makefile: Fix 'rh-configs' and 'fedora-configs' targets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 31, 2020 at 02:55:54PM -0000, GitLab Bridge on behalf of prarit wrote:
>  dist-configs-prep: dist-clean-configs
> -	cd $(REDHAT)/configs; TARGET=$(DIST_TARGET) ./build_configs.sh $(PACKAGE_NAME) $(ARCH_MACH)
> +	cd $(REDHAT)/configs; ./build_configs.sh $(PACKAGE_NAME) $(ARCH_MACH)
> +
> +fedora-configs: dist-configs-prep
> +	@cd $(REDHAT)/configs; rm -f *rhel*.config
> +
> +rh-configs: dist-configs-prep
> +	@cd $(REDHAT)/configs; rm -f *fedora*.config
>  

My concern here is the skipping of process_configs.sh.  While this is slow
and painful, the question is what is the expectation of the config output?
A mashed up collection of configs that falsely claims a config is enabled or
the final kconfig process'd configs that reflects the true result of the
config option?

BTW, you can cut the process_configs.sh time in half by _really_ skipping
the checks instead of running the checks and skipping the results.

Cheers,
Don
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux