Re: [OS-BUILD PATCHv2] redhat/Makefile: Fix 'rh-configs' and 'fedora-configs' targets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/31/20 11:15 AM, Jiri Benc wrote:
> On Fri, 31 Jul 2020 14:55:54 -0000, GitLab Bridge on behalf of prarit wrote:
>> +fedora-configs: dist-configs-prep
>> +	@cd $(REDHAT)/configs; rm -f *rhel*.config
>> +
>> +rh-configs: dist-configs-prep
>> +	@cd $(REDHAT)/configs; rm -f *fedora*.config
> 
> Prarit, I wouldn't expect doing
> 
> make fedora-configs
> make rh-configs
> 
> in succession resulting in only rhel configs being present.

Oh good point.

> 
> Could we do better? Enhancing build_configs.sh to support flavors being
> specified on command line and falling back to the 'flavors' file only
> when there are none specified seems to me to be a better approach. It
> would also speed up the config generation.

This is definitely a better approach.  I'll go that route.

P.

> 
> Thanks,
> 
>  Jiri
> 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux