Re: [OS-BUILD PATCH] s390x-zfcpdump: Handle missing Module.symvers file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 26, 2020 at 07:41:19PM -0000, GitLab Bridge on behalf of dzickusrh wrote:
> From: Don Zickus <dzickus@xxxxxxxxxx>
> 
> In 5.8-rc1, a change was made to not always generate a Module.symvers
> file if no modules were built.  The s390x zfcpdump variant is a kernel
> that is built with no modules enabled.
> 
> The kernel.spec file assumes Module.symvers always exists and fails to
> build the zfcpdump variant.
> 
> Modify the spec file to detect the missing file and 'touch' it as a
> workaround.  This file is used utilized by the kabi technology.  There
> is probably a better long term fix, but this is the quick and easy fix.
> 
> Tested locally using cross-compilers.
> ---
>  redhat/kernel.spec.template | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template
> index c9eb8f1fca2e..81fb0c876286 100644
> --- a/redhat/kernel.spec.template
> +++ b/redhat/kernel.spec.template
> @@ -1523,6 +1523,9 @@ BuildKernel() {
>      find . -name *.h.s -delete
>      # first copy everything
>      cp --parents `find  -type f -name "Makefile*" -o -name "Kconfig*"` $RPM_BUILD_ROOT/lib/modules/$KernelVer/build
> +    if [ ! -e Module.symvers ]; then
> +        touch Module.symvers
> +    fi
>      cp Module.symvers $RPM_BUILD_ROOT/lib/modules/$KernelVer/build
>      cp System.map $RPM_BUILD_ROOT/lib/modules/$KernelVer/build
>      if [ -s Module.markers ]; then

Acked-by: Herton R. Krzesinski <herton@xxxxxxxxxx>

-- 
[]'s
Herton
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux