On Wed, Jun 24, 2020 at 03:37:06PM -0000, GitLab Bridge on behalf of prarit wrote: > From: Prarit Bhargava <prarit@xxxxxxxxxx> > > Upstream Status: RHEL only > > After discussions with Devel, QE, Support, and Certification we have > decided to drop the CPU specific checks in rh_check_supported(). > Certification is adopting a new process in which CPU certifications will > be tracked on https://catalog.redhat.com. > > Remove the vendor specific CPU ID checks from rh_check_supported(). Acked-by: Don Zickus <dzickus@xxxxxxxxxx> I could argue the whole rh_check_supported() could go. The whole single cpu was added because we didn't have processor family filtering. With that in place now, do you know of any Haswell or later cpus that are single cpus? Or same question for AMD supported families? That leaves the default 'processor unsupported'. Using the same logic in the changelog, we could probably drop that too??? Is that too aggressive? :-) Cheers, Don > > Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx> > Cc: David Arcari <darcari@xxxxxxxxxx> > --- > arch/x86/kernel/setup.c | 85 ----------------------------------------- > 1 file changed, 85 deletions(-) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 6d31895c8e92..4e43f6957621 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -757,72 +757,6 @@ static void __init trim_low_memory_range(void) > } > > #ifdef CONFIG_RHEL_DIFFERENCES > -static bool valid_amd_processor(__u8 family, const char *model_id) > -{ > - bool valid; > - > - switch(family) { > - case 0x15: > - valid = true; > - break; > - > - case 0x17: > - valid = strstr(model_id, "AMD EPYC 7"); > - break; > - > - default: > - valid = false; > - break; > - } > - > - return valid; > -} > - > -static bool valid_intel_processor(__u8 family, __u8 model, __u8 stepping) > -{ > - bool valid; > - > - if (family != 6) > - return false; > - > - switch(model) { > - case INTEL_FAM6_ATOM_GOLDMONT_D: > - case INTEL_FAM6_ATOM_GOLDMONT_PLUS: > - > - case INTEL_FAM6_BROADWELL: > - case INTEL_FAM6_BROADWELL_G: > - case INTEL_FAM6_BROADWELL_X: > - case INTEL_FAM6_BROADWELL_D: > - > - case INTEL_FAM6_HASWELL: > - case INTEL_FAM6_HASWELL_G: > - case INTEL_FAM6_HASWELL_L: > - case INTEL_FAM6_HASWELL_X: > - valid = true; > - break; > - > - case INTEL_FAM6_KABYLAKE: > - valid = (stepping <= 10); > - break; > - > - case INTEL_FAM6_KABYLAKE_L: > - valid = (stepping <= 11); > - break; > - > - case INTEL_FAM6_SKYLAKE_L: > - case INTEL_FAM6_SKYLAKE: > - case INTEL_FAM6_SKYLAKE_X: > - /* stepping > 4 is Cascade Lake and is not supported */ > - valid = (stepping <= 4); > - break; > - > - default: > - valid = false; > - break; > - } > - > - return valid; > -} > > static void rh_check_supported(void) > { > @@ -843,27 +777,8 @@ static void rh_check_supported(void) > */ > switch (boot_cpu_data.x86_vendor) { > case X86_VENDOR_AMD: > - if (!valid_amd_processor(boot_cpu_data.x86, > - boot_cpu_data.x86_model_id)) { > - pr_crit("Detected CPU family %xh model %d\n", > - boot_cpu_data.x86, > - boot_cpu_data.x86_model); > - mark_hardware_unsupported("AMD Processor"); > - } > - break; > - > case X86_VENDOR_INTEL: > - if (!valid_intel_processor(boot_cpu_data.x86, > - boot_cpu_data.x86_model, > - boot_cpu_data.x86_stepping)) { > - pr_crit("Detected CPU family %d model %d stepping %d\n", > - boot_cpu_data.x86, > - boot_cpu_data.x86_model, > - boot_cpu_data.x86_stepping); > - mark_hardware_unsupported("Intel Processor"); > - } > break; > - > default: > pr_crit("Detected processor %s %s\n", > boot_cpu_data.x86_vendor_id, > -- > GitLab > _______________________________________________ > kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
