Re: [OS-BUILD PATCHv2] redhat/Makefile: Add fedora-configs and rh-configs make targets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 18, 2020 at 01:01:25PM -0400, Prarit Bhargava wrote:
> On 6/18/20 12:52 PM, Don Zickus wrote:
> > On Wed, Jun 17, 2020 at 03:44:16PM -0000, GitLab Bridge on behalf of prarit wrote:
> >> From: Prarit Bhargava <prarit@xxxxxxxxxx>
> >>
> >> There are times when I have to generate both Fedora and RHEL configs.
> > 
> > I believe 'make dist-configs' does this by default, builds both??
> > 
> 
> That's not what I see.  From the messages:
> 
> cd /home/prarit/git-kernel/kernel-ark/redhat/configs; TARGET=fedora
> ./build_configs.sh kernel
> 
> where TARGET is defined by DIST_TARGET, which is
> 
> ifeq ("$(IS_FEDORA)", "1")
>    DIST_TARGET=fedora
> else
>    DIST_TARGET=rhel
> endif
> 
> IS_FEDORA, is
> 
> IS_FEDORA:=$(shell ! echo $(DIST) | grep -q fc; echo $$?)
> 
> IOW, you have to be on Fedora to get Fedora configs, and on RHEL to get RHEL
> configs *or* use
> 
> make dist-configs IS_FEDORA=0 # for RHEL
> make dist-configs IS_FEDORA=1 # for Fedora
> 
> which is an annoying to my doggie-sized brain :).

Nevermind.  I was confused on the output of 'make dist-configs'.

The command _merges_ both distros, but based on the DIST it processes that
distro and removes the other one.

So the output shows all the rhel and fedora configs being merged, but only
one or the other being processed.  Processing is already slow, no need to
combine that too.

Sorry for the noise.

Cheers,
Don
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux