On Thu, May 14, 2020 at 7:45 AM Prarit Bhargava <prarit@xxxxxxxxxx> wrote: > > Jiri & I have noted that there are many mentions of the "RHEL" throughout the > ARK kernel patches and redhat directory. > > In my previous patch jbenc noted: > > >>> --- a/redhat/scripts/download_cross.sh > >>> +++ b/redhat/scripts/download_cross.sh > >>> @@ -26,7 +26,7 @@ fi > >>> > >>> # if we're not root, all we can do now is see what's installed > >>> if [ "$(whoami)" != "root" ]; then > >>> - echo "Checking for RHEL7 cross compile packages. If this fails, run \"make rh-cross-download\" as root." > >>> + echo "Checking for RHEL7 cross compile packages. If this fails, run \"make dist-cross-download\" as root." > >> > >> Please change the "RHEL7" as well. > > And I replied: > > > I noticed the RHEL7 (and other RHEL) mentions as well but felt that they are out of scope for this changeset. I was planning on coming to the list to ask what we should change the "RHEL" phrase to. Distribution? > > > > I'll start a new thread on that. There are other mentions throughout the kernel, for example, "RHEL_MAJOR" and "RHEL_MINOR", andsome of the patches include the phrase "RHEL only". We need to have a consistent policy at modifying all of those. > > > > 1. Does "DIST"/"Distribution"/"dist" work as a replacement? > 2. Do we want to make that change across the kernel? > 3. It makes sense to me to fix these in the redhat/ directory. Do we want to > change the "RHEL only" mentions in the patches to something else? "DIST only" > seems wonky. > 4. We need to rename the redhat/ dir to something else as well. > This is probably way more trouble than it's worth. The mentions of RHEL versions in strings could probably just be changed to things like EL7 or EL8, but we already use rh-* and redhat in enough other places as API that I don't think that it's a problem. Heck, we have a redhat-rpm-config package with a redhat folder inside, and the rpm vendor is "redhat". This is not one of those things that's worth going nuts over. :) -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
