Re: [OS-BUILD PATCH] redhat: Change Makefile target names to dist-

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/14/20 4:55 AM, Jiri Benc wrote:
> On Wed, 13 May 2020 23:03:12 -0000, GitLab Bridge on behalf of prarit wrote:
>> +	@echo  '  dist-srpm       - Create a source RPM and put it into the redhat/rpm/SRPMS/ directory.'
>> +	@echo  '                  See the dist-brew target for available options.'
> 
> The help lines are no longer aligned correctly. Please ensure that the
> output of both 'make dist-help' and 'make dist-full-help' is formatted
> correctly.

I'll fix that.

> 
>> --- a/redhat/scripts/download_cross.sh
>> +++ b/redhat/scripts/download_cross.sh
>> @@ -26,7 +26,7 @@ fi
>>  
>>  # if we're not root, all we can do now is see what's installed
>>  if [ "$(whoami)" != "root" ]; then
>> -	echo "Checking for RHEL7 cross compile packages.  If this fails, run \"make rh-cross-download\" as root."
>> +	echo "Checking for RHEL7 cross compile packages.  If this fails, run \"make dist-cross-download\" as root."
> 
> Please change the "RHEL7" as well.

I noticed the RHEL7 (and other RHEL) mentions as well but felt that they are out
of scope for this changeset.  I was planning on coming to the list to ask what
we should change the "RHEL" phrase to.  Distribution?

I'll start a new thread on that.  There are other mentions throughout the
kernel, for example, "RHEL_MAJOR" and "RHEL_MINOR", andsome of the patches
include the phrase "RHEL only".  We need to have a consistent policy at
modifying all of those.

P.

> 
> Politely, requesting a new version,
> Nacked-by: Jiri Benc <jbenc@xxxxxxxxxx>
> 
> Thanks,
> 
>  Jiri
> _______________________________________________
> kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
> 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux