On Thu, 14 May 2020 01:41:12 -0000, GitLab Bridge on behalf of dzickusrh wrote: > @@ -363,6 +367,7 @@ rh-help: > @echo ' rh-cross-all-rpms - Build RPMs for all supported archs using a cross compiler.' > @echo '' > @echo 'Configuration targets:' > + @echo ' rh-gitsetup - include redhat/kernel.gitconfig in repo git config' Please make this a full sentence, starting with a capital letter and ending with a period to match the other help texts. Also, in the basic rh-help, avoid explaining what is going on under the hood but explain what is the effect of the target. Saying "include another gitconfig" is not helpful without looking into that file. The help text should rather be something like "Adjust git repo configuration for Fedora/CentOS/RHEL workflow." In the rh-full-help, you can elaborate on that. Lastly, you'll have to sync with Prarit's rh -> dist conversion, these two patches collide. Politely, Nacked-by: Jiri Benc <jbenc@xxxxxxxxxx> Jiri _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
