Re: RFC: Adding "Requires: alsa-sof-firmware" to F31 kernel-modules pkgs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne 30. 04. 20 v 11:00 Hans de Goede napsal(a):
Hi,

On 4/29/20 4:57 PM, Justin Forbes wrote:


On Wed, Apr 29, 2020 at 9:50 AM Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote:

     Hi,

     On 4/29/20 4:12 PM, Peter Robinson wrote:
      > On Wed, Apr 29, 2020 at 1:57 PM Justin Forbes <jforbes@xxxxxxxxxx <mailto:jforbes@xxxxxxxxxx>> wrote:
      >>
      >> On Wed, Apr 29, 2020 at 7:49 AM Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote:
      >>
      >>> Hi,
      >>>
      >>> On 4/29/20 11:58 AM, Hans de Goede wrote:
      >>>> Hi All,
      >>>>
      >>>> As discussed before the new SOF audio driver needed for audio to
      >>>> function properly on recent Intel based laptops needs the
      >>>> alsa-sof-firmware package.
      >>>>
      >>>> For F32 this has been added to comps, but for F31 and for people
      >>>> upgrading from F31, we are still getting bug reports that audio
      >>>> does not work with newer kernels, see e.g. :
      >>>>
      >>>> https://bugzilla.redhat.com/show_bug.cgi?id=1806334
      >>>>
      >>>> So we need to do something for F31 ASAP (and rely on people fully
      >>>> updating F31 before upgrading to fix upgrades to F32).
      >>>>
      >>>> My proposal still is to add a:
      >>>>
      >>>> Requires: alsa-sof-firmware
      >>>>
      >>>> To the F31 (and F30) kernel-modules sub-package.
      >>>>
      >>>> If I receive no objections to this I will add this change
      >>>> to distgit soon , so that it can be picked up by the next
      >>>> kernel build.
      >>>>
      >>>> Or even better if the maintainer of the current F30/F31
      >>>> kernel can do this before the next build, that would be
      >>>> great.
      >>>
      >>> And we just got the 3th bug report for this in 2 days:
      >>>
      >>> https://bugzilla.redhat.com/show_bug.cgi?id=1772498#c240
      >>>
      >>> Again after an upgrade to Fedora 32 (I guess people were
      >>> sticking with an older kernel on F31).
      >>>
      >>> I think we should consider also adding the Requires to
      >>> the F32 kernel-modules and rely on the comps thing for
      >>> F33 and later only.
      >>>
      >>
      >> I am not particularly happy with having to add it when the majority of
      >> systems do not actually require it, but I have seen the bugs and understand
      >> the position we are in. The alsa-sof-firmware package is 384k, I think
      >> adding it might be the best course of action.
      >
      > Can we do a recommends rather than a hard requires please?

     Good point, yes that should work fine, while allowing people who
     really don't want it / want to save the space to opt out.

     So lets go with the Recommends.


Sure, I can add it to all of the 5.6.8 builds.

Great, thank you.

I don't think that we need to add this dependency for F32+ kernels. I though that it should resolve only the F31 specific issue (F32 has updated comps which follows the other additional firmware files like for Intel WiFi driver or so...). I would remove this for F32+ kernels. Also this firmware is only for x86_64 arch (missing condition).

https://src.fedoraproject.org/rpms/kernel/blob/f32/f/kernel.spec#_1260

				Thanks,
					Jaroslav


Regards,

Hans
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx



--
Jaroslav Kysela <jkysela@xxxxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux