On Thu, Oct 10, 2019 at 02:59:39PM +0200, Paul Bolle wrote:
> Javier Martinez Canillas schreef op do 10-10-2019 om 13:38 [+0200]:
> > configs/fedora/generic/CONFIG_EFI_TEST | 2 +-
> > [...]
> > kernel-aarch64-debug.config | 2 +-
> > kernel-aarch64.config | 2 +-
> > kernel-armv7hl-debug.config | 2 +-
> > kernel-armv7hl-lpae-debug.config | 2 +-
> > kernel-armv7hl-lpae.config | 2 +-
> > kernel-armv7hl.config | 2 +-
> > kernel-i686-debug.config | 2 +-
> > kernel-i686.config | 2 +-
> > kernel-x86_64-debug.config | 2 +-
> > kernel-x86_64.config | 2 +-
>
> You enabled it globally ("generic") but no changes show up in the shipped
> .config files for ppc64le or in s390x. So you didn't run build_configs.sh, did
> you?
>
Not sure what other maintainers do, but I prefer to just run
build_configs.sh myself rather than get it as part of the patch. It
makes reviewing the patch easier.
Really it should be run pre-build automatically, and that might start
happening in the not-to-distant future.
> > --- a/configs/fedora/generic/CONFIG_EFI_TEST
> > +++ b/configs/fedora/generic/CONFIG_EFI_TEST
> > @@ -1 +1 @@
> > -# CONFIG_EFI_TEST is not set
> > +CONFIG_EFI_TEST=m
>
> If my grepping of the upstream tree is correct EFI is indeed not relevant for
> powerpc or s390. So I think you should not set this globally, but only for the
> other four arches (as you tried to do above, but incorrectly). I think it
> would be easiest to disable this in .../powerpc/CONFIG_EFI_TEST and
> ../s390x/CONFIG_EFI_TEST.
>
Indeed, and when I applied this I flipped it off for s390 and ppc.
Thanks for the review.
- Jeremy
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
