Re: [PATCH] [RFC] Drop non-x86 debug .config files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 16, 2019 at 5:52 AM Paul Bolle <pebolle@xxxxxxxxxx> wrote:
>
> We only do debug builds on x86. Drop the debug .config files for the
> other arches.
>
Absolutely not true.   Every rawhide build outside of direct rcX
builds are debug builds.  Stable releases don't use these files.

> Not-yet-signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> What would break if this patch were applied? Because, as far as I can
> tell, none of these five debug .config files are ever used. I must be
> overlooking something here.
>
generate_debug_configs.sh

>  configs/config_generation                 |    5 -
>  configs/fedora/debug/arm/CONFIG_LOCK_STAT |    1 -
>  kernel-aarch64-debug.config               | 6945 -------------------
>  kernel-armv7hl-debug.config               | 7360 ---------------------
>  kernel-armv7hl-lpae-debug.config          | 6924 -------------------
>  kernel-ppc64le-debug.config               | 6061 -----------------
>  kernel-s390x-debug.config                 | 6001 -----------------
>  kernel.spec                               |    4 -
>  8 files changed, 33301 deletions(-)
>  delete mode 100644 configs/fedora/debug/arm/CONFIG_LOCK_STAT
>  delete mode 100644 kernel-aarch64-debug.config
>  delete mode 100644 kernel-armv7hl-debug.config
>  delete mode 100644 kernel-armv7hl-lpae-debug.config
>  delete mode 100644 kernel-ppc64le-debug.config
>  delete mode 100644 kernel-s390x-debug.config
>
> diff --git a/configs/config_generation b/configs/config_generation
> index 97683c517ef5..1105c76294c5 100644
> --- a/configs/config_generation
> +++ b/configs/config_generation
> @@ -18,18 +18,13 @@ i686-debug=generic:generic-x86:generic-x86-i686:debug:debug-x86
>
>  # ppc64le
>  ppc64le=generic:generic-powerpc
> -ppc64le-debug=generic:generic-powerpc:generic-powerpc:debug
>
>  # s390x
>  s390x=generic:generic-s390x
> -s390x-debug=generic:generic-s390x:debug
>
>  # aarch64
>  aarch64=generic:generic-arm:generic-arm-aarch64
> -aarch64-debug=generic:generic-arm:generic-arm-aarch64:debug:debug-arm
>
>  # arm
>  armv7hl=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-armv7
> -armv7hl-debug=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-armv7:debug:debug-arm
>  armv7hl-lpae=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-lpae
> -armv7hl-lpae-debug=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-lpae:debug:debug-arm
> diff --git a/configs/fedora/debug/arm/CONFIG_LOCK_STAT b/configs/fedora/debug/arm/CONFIG_LOCK_STAT
> deleted file mode 100644
> index ab733ddc26ab..000000000000
> diff --git a/kernel-aarch64-debug.config b/kernel-aarch64-debug.config
> deleted file mode 100644
> index 64d751925307..000000000000
> diff --git a/kernel-armv7hl-debug.config b/kernel-armv7hl-debug.config
> deleted file mode 100644
> index 0a318bfee7c1..000000000000
> diff --git a/kernel-armv7hl-lpae-debug.config b/kernel-armv7hl-lpae-debug.config
> deleted file mode 100644
> index 0ce99e3ffe96..000000000000
> diff --git a/kernel-ppc64le-debug.config b/kernel-ppc64le-debug.config
> deleted file mode 100644
> index 65f00540bc70..000000000000
> diff --git a/kernel-s390x-debug.config b/kernel-s390x-debug.config
> deleted file mode 100644
> index 53a7647c14c2..000000000000
> diff --git a/kernel.spec b/kernel.spec
> index 23b8c13475d6..1b6e52d8ffae 100644
> --- a/kernel.spec
> +++ b/kernel.spec
> @@ -1565,10 +1565,6 @@ cd linux-%{KVERREL}
>  BuildKernel %make_target %kernel_image %{_use_vdso} debug
>  %endif
>
> -%if %{with_pae_debug}
> -BuildKernel %make_target %kernel_image %{use_vdso} %{pae}debug
> -%endif
> -
>  %if %{with_pae}
>  BuildKernel %make_target %kernel_image %{use_vdso} %{pae}
>  %endif
> --
> 2.17.2
> _______________________________________________
> kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux