2017-07-24 15:28 GMT+02:00 Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>:
> On Mon, Jul 24, 2017 at 9:20 AM, Nicolas Chauvet <kwizart@xxxxxxxxx> wrote:
>
> Please add a descriptive changelog to the patch. People shouldn't
> have to go somewhere else to see why a change is being made. I even
> read the bug and still don't fully understand what problem you're
> trying to solve.
>
>> ---
>> kernel.spec | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/kernel.spec b/kernel.spec
>> index 6e2df747..377b71a0 100644
>> --- a/kernel.spec
>> +++ b/kernel.spec
>> @@ -382,6 +382,11 @@ ExclusiveOS: Linux
>> %ifnarch %{nobuildarches}
>> Requires: kernel-core-uname-r = %{KVERREL}%{?variant}
>> Requires: kernel-modules-uname-r = %{KVERREL}%{?variant}
>> +# Enforce kernel-devel varriant >= uname-r,varriant if installed - rhbz#1450577
>> +# Only needed for fedora kernel
>> +%if 0%{?fedora}
>
> Why is a fedora conditional being added here? This is only built in
> Fedora already, and the spec file isn't shared with another downstream
> directly.
This is true, however I remember centos armhfp altarch often rebase on
fedora kernel.
>> +Requires: (kernel-devel-uname-r >= %{KVERREL}%{?variant} if kernel-devel-uname-r)
>
> Adding this seems to now force this installation of a kernel-devel
Well, this is not the case, as it's a boolean dependency. It will
enforce the condition only if there is already a kernel-devel-uname
variant.
(fixed the typo variant, btw).
Thx
--
-
Nicolas (kwizart)
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
